[pull] master from ruby:master - #1447
Merged
Merged
Conversation
JRuby on Windows loads its bundled `win32/resolv`, which has no `tcpip_params`, so two of these tests raised NoMethodError there. ruby/resolv@971a36ee72 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PROCESSOR_FLAG lost its only definition in cdb9893, so ARCH_FLAG has been empty unless given explicitly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MSVC 1915 or later is required and Makefile.sub rejects RT_VER below 140, so the values made for msvcrt and msvcrNN only led to that error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Only the Cygwin branch in localeinit.c calls nl_langinfo_codeset, so on mswin the object just added an unused export to the DLL. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Building ruby needs `_MSC_VER` 1915 or later, but the generated config.h accepts 1910 and later for such a build, so an extension could still be compiled by 1910 through 1914. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every `RBIMPL_COMPILER_SINCE(MSVC, ...)` condition here holds for `_MSC_VER` 1915, the oldest version the headers accept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The last use went away in cdb9893. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The fallback definitions were for Visual C++ 2008 and older, which had no stdint.h. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It was for Visual C++ 2012 and older, which had no inttypes.h. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
malloc.h, which win32.h includes, declares it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On Windows, File.unlink raises Errno::EACCES while another handle still holds the file open. Tempfile#unlink already ignores that, but FinalizerManager#call only rescued ENOENT, so the exception escaped from the GC finalizer and was reported on stderr. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Redefining the method warns under RUBYOPT=-w, which CI uses, and the test expects nothing on stderr. Prepending a module leaves the original method in place. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )