[pull] master from ruby:master - #1454
Merged
Merged
Conversation
…rmed Dependency names were written into %q<> without escaping, and specification_version, dependency types and stub line values were interpolated as is, so a stray `\`, `>` or newline changed the structure of the generated gemspec. Dump dependency names with ruby_code and raise for values that cannot be written safely. ruby/rubygems@07fce12110 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Gem::Specification#to_ruby now escapes these values or raises for them, so such a spec fails in ensure_loadable_spec as corrupt. Call to_ruby inside its rescue so that failure is reported the same way. ruby/rubygems@008e87008d Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
LONG2FIX does not check the range, so `[1].cycle(2**30).size` returned -1073741824 on mswin. 64-bit platforms hit the same with 2**62. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The child dies with SIGSEGV in about a quarter of the Windows 11-arm check runs on master, and leaves no [BUG] report to go on. It has not shown up on x64 Windows, Linux or macOS. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Windows 7 and older could not write more than about 64KB to a console in one call, so console writes and binary writes to character devices were split into 31366-unit pieces [Bug #14942]. Windows older than 8 has not been supported since [Feature #20563], and a single 1MB write succeeds on Windows 11 with conhost, with and without VT processing, and with Windows Terminal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The fix in commit 11f57c6 contained a bug where the calculated index should be `len - i` and not `len - 1`. This script reproduces the crash: ary = (1..100).to_a gen = Object.new gen.define_singleton_method(:rand) { |lim| 8 } nv = Object.new nv.define_singleton_method(:to_int) { ary.replace(Array.new(10) { :x }); 10 } p ary.sample(nv, random: gen)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )