Skip to content

Add pure fusion rate profiles - #4654

Merged
je-cook merged 8 commits into
mainfrom
add_pure_fusion_rate_profiles
Oct 12, 2026
Merged

je-cook merged 8 commits into
mainfrom
add_pure_fusion_rate_profiles

Conversation

@chris-ashe

@chris-ashe chris-ashe commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Description

Following on from plotting put in for the radiation in #4625 . The true space profiles for the fusion reactions both in log and linear scale have been added.

image

🐛

Some text overlap problems have also been fixed as noted by issue #4667

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@codecov-commenter

codecov-commenter commented Oct 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 3.38983% with 57 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.80%. Comparing base (de7f23e) to head (7563187).

Files with missing lines Patch % Lines
process/core/io/plot/summary.py 3.38% 57 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4654      +/-   ##
==========================================
- Coverage   49.88%   49.80%   -0.08%     
==========================================
  Files         151      151              
  Lines       30220    30269      +49     
==========================================
+ Hits        15074    15075       +1     
- Misses      15146    15194      +48     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chris-ashe
chris-ashe marked this pull request as ready for review October 9, 2026 12:48
@chris-ashe
chris-ashe requested a review from a team as a code owner October 9, 2026 12:48
@chris-ashe
chris-ashe requested review from clmould and removed request for clmould October 9, 2026 12:50

@je-cook je-cook left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to have the legend located in the top right/left? In the linear scale isnt one of the interesting sections under the legend?

@je-cook je-cook self-assigned this Oct 12, 2026
@chris-ashe
chris-ashe force-pushed the add_pure_fusion_rate_profiles branch from 93265ad to 5255aef Compare October 12, 2026 14:41
@chris-ashe

Copy link
Copy Markdown
Member Author

Would it be better to have the legend located in the top right/left? In the linear scale isnt one of the interesting sections under the legend?

Done

@je-cook
je-cook enabled auto-merge (squash) October 12, 2026 15:23
@je-cook
je-cook merged commit 3132913 into main Oct 12, 2026
10 of 11 checks passed
@je-cook
je-cook deleted the add_pure_fusion_rate_profiles branch October 12, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants