Skip to content

Add cs alpha beta - #4670

Merged
timothy-nunn merged 6 commits into
mainfrom
add_cs_alpha_beta
Oct 15, 2026
Merged

timothy-nunn merged 6 commits into
mainfrom
add_cs_alpha_beta

Conversation

@chris-ashe

Copy link
Copy Markdown
Member

Description

Add the CS coil $\alpha$ and $\beta$ dimension variables to calculation and output

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

Comment thread process/models/pfcoil.py Outdated
f_r_cs_outer_inner = r_cs_coil_outer / r_cs_coil_inner

# Ratio of the solenoid half height to its inner radius, also known as β (beta)
f_len_cs_upper_inner = z_cs_coil_upper / r_cs_coil_inner

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's minor but I think this should read:

z_cs_half / r_cs_coil_inner

Lest z_cs_coil_middle ever be changed from 0.0, this will be one less thing to worry about.

@timothy-nunn timothy-nunn self-assigned this Oct 14, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.28%. Comparing base (95c71b6) to head (c998751).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
process/models/pfcoil.py 70.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4670      +/-   ##
==========================================
- Coverage   50.31%   50.28%   -0.04%     
==========================================
  Files         181      181              
  Lines       30458    30525      +67     
==========================================
+ Hits        15326    15348      +22     
- Misses      15132    15177      +45     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn
timothy-nunn merged commit d1f651a into main Oct 15, 2026
8 of 11 checks passed
@timothy-nunn
timothy-nunn deleted the add_cs_alpha_beta branch October 15, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants