Repository navigation
TF Temperature margin improvements: calculation and de-discombobulation #4689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
bd53d42
090b2f6
ecf7c67
8f2c9de
025d043
b62c307
577dd18
7fad54b
6f8848b
7a05478
45d41b5
e4de6c3
7289cc1
cca3e56
c09fcd9
3a1b3e2
de3d9b5
0b4ad62
b4783a9
479455a
75119bf
7af2676
5c59623
2c7f632
434d2b5
a37ddd4
d3c60c3
7756860
9136245
6bd9d0c
630444e
101384d
fde4482
efb9acb
c9535a7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -997,18 +997,19 @@ def constraint_equation_35(constraint_registration, data): | |
| ) | ||
|
|
||
|
|
||
| @ConstraintManager.register_constraint(36, "K", ">=") | ||
| @ConstraintManager.register_constraint(36, "A/m²", "<=") | ||
| def constraint_equation_36(constraint_registration, data): | ||
| """Equation for TF coil s/c temperature margin lower limit (SCTF) | ||
| by means of the actual to critical current density | ||
|
|
||
| temp_tf_superconductor_margin: | ||
| TF coil temperature margin (K) | ||
| temp_tf_superconductor_margin_min: | ||
| minimum allowable temperature margin : TF coils (K) | ||
| j_tf_wp: | ||
| winding pack current density (A/m²) | ||
| j_tf_wp_temp_margin: | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This isn't a temperature margin right? It's a current density, so we should change this variable name to reflect that.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, it's a current density. I named it to be in line with the other similar variables:
Happy to rename |
||
| superconducting strand critical current density (A/m²) | ||
| """ | ||
| return geq( | ||
| data.tfcoil.temp_tf_superconductor_margin, | ||
| data.tfcoil.temp_tf_superconductor_margin_min, | ||
| return leq( | ||
| data.tfcoil.j_tf_wp, | ||
| data.tfcoil.j_tf_wp_temp_margin, | ||
| constraint_registration, | ||
| ) | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the description is a bit back to front now as we're limiting current density primarily maybe something like this is more accurate