Repository navigation
fix(header): preserve mobile banner proportions - #2788
Eli Bosley (elibosley) wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe consolidated header banner retains its desktop background sizing. Below 640px, it uses cover sizing and centered positioning. The desktop explanatory comment is shorter. ChangesHeader Banner
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to
|
🔧 PR Test Plugin AvailableA test plugin has been generated for this PR that includes the modified files. Version: 📥 Installation Instructions:Install via Unraid Web UI:
Alternative: Direct Download
|
Summary
Preserve banner image proportions on mobile while retaining the existing desktop sizing.
Related independent API header refinement: unraid/api#2111. This stylesheet fix also applies to the existing consolidated header.
Why This Exists
The consolidated header stretches its background to
100% 100%, which squashes the banner on mobile as the header becomes taller.Resolution
Below 640px, use centered
coversizing on the outer WebGUI header. Keep100% 100%sizing from 640px upward.Reviewer Considerations
Mobile crops the banner edges to preserve its proportions. The outer header belongs to WebGUI, so the rule lives in its stylesheet.
Behavior Changes
Mobile banners scale uniformly and crop from the center. Desktop and legacy header sizing stay unchanged.
Implementation Summary
Add one mobile media query for
#header.unraid-consolidated-headerindefault-base.css.Verification
git diff --checkpassed at12e8600f3f9f7286259a9787fa75902b0f74df98.cover; 640, 768, 1440, and 2560px retain100% 100%.Risk
Low; one selector changes only below the existing mobile breakpoint. Cropping is intentional on mobile.
Summary by CodeRabbit