[phndiaye]

What does this PR do?

In order to deprecate ember-cli-ifa, which does too many things at build-time while being an addon (which doesn't fit very well w/ migration to Vite), this PR introduces a:

• an asset-map service/helper duo
• a build-time function allowing consumer apps to intentionally opt-in to the behaviour ember-cli-ifa brought

ember-cli-ifa was used to make our lives easier when using assets with dynamically built paths (e.g: @upfluence/oss-components/assets/${someVariable}.svg).

We use the exact same helper/service names as exported by ember-cli-ifa (asset-map) so we have drop-in replacement inside our runtime code, and we just have to update the apps' ember-cli-build.js file.

What are the observable changes?

Warning

This is a transition tooling
In an ideal and modern world, we would just do import mySvgFile from './my-svg-file.svg and > use it in components.
And in case of dynamic asset, we would import them all, then in the code handle the conditions to return the right ones, opening the door for tree-shaking to avoid publishing unused assets to consumers.

Until we reach that stage, this PR unlocks some improvements while allowing to work as usual.

Good PR checklist

• Title makes sense
• Is against the correct branch
• Only addresses one issue
• Properly assigned
• Added/updated tests
• Added/updated documentation with Figma design link. Don't forget to replace "design" by "file" in the URL. For example https://www.figma.com/file/example
• Migrated touched components to Glimmer Components
• Properly labeled

[phndiaye]

This has been spotted by a Vite migration attempt. The addon files don't export faIconStyle, same for fa-icon-value and redirect-to helpers.

[Copilot]

🟡 Changes recommended

Node compatibility, SSR initialization, and the documented consumer migration path remain unresolved.

3 open findings

• FastBoot asset-map lookup fails without document · New
• Declared Node support is incompatible with fs.cpSync · New
• injectAssetMap requires undocumented HTML placeholder edits · New

What changed in this PR

Introduces an ember-cli-ifa replacement that injects asset manifests at build time and resolves assets through an Ember service/helper.

Changes:

• Adds asset-map build injection and runtime resolution.
• Adds unit, integration, and build tests.
• Removes ember-cli-ifa and updates CI/dependencies.

File	Description
.github/​workflows/​ci.yml	Runs asset-map build tests.
addon/​helpers/​asset-map.ts	Adds the asset-map helper.
addon/​services/​asset-map.ts	Adds manifest validation and URL resolution.
app/​helpers/​asset-map.js	Exposes the helper to consumers.
app/​helpers/​fa-icon-style.js	Removes obsolete named export.
app/​helpers/​fa-icon-value.js	Removes obsolete named export.
app/​helpers/​redirect-to.js	Removes obsolete named export.
app/​services/​asset-map.js	Exposes the service to consumers.
build/​classic-asset-map.cjs	Implements build-time manifest injection.
ember-cli-build.js	Enables the adapter in the dummy app.
package.json	Updates dependencies and test scripts.
pnpm-lock.yaml	Locks dependency changes.
tests/​build/​asset-map-test.cjs	Tests build-time behavior and failures.
tests/​dummy/​app/​index.html	Adds the manifest placeholder.
tests/​index.html	Adds the test manifest placeholder.
tests/​integration/​helpers/​asset-map-test.ts	Tests helper behavior and reactivity.
tests/​unit/​services/​asset-map-test.ts	Tests service validation and resolution.

Files not reviewed (1)

• pnpm-lock.yaml: Generated file

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🔵 Needs a closer look

The resolver can bypass valid fingerprint mappings when logical paths overlap the configured base path.

1 open finding

• injectAssetMap requires undocumented HTML placeholder edits

2 resolved since last review

• Declared Node support is incompatible with fs.cpSync
• FastBoot asset-map lookup fails without document

Files not reviewed (1)

• pnpm-lock.yaml: Generated file

Previously missed (1)

In code that hasn't changed since last review

Leading-slash paths bypass fingerprint manifest mappings

addon/​services/​asset-map.ts:53

This shortcut skips a valid fingerprint mapping when a logical path overlaps the consumer's base path. With rootURL: '/assets/' and assets/logo.svg → assets/logo-123.svg, resolving /assets/logo.svg returns the unhashed input, while assets/logo.svg resolves to /assets/assets/logo-123.svg. This breaks leading-slash normalization and can request a file removed by fingerprinting. Only apply this shortcut when the normalized name is not a manifest key, and add a regression test for this overlap.

🧠 Review effort: Balanced

[linear-code]

VEL-8567

[JulienVannier66]

LGTM

[JulienVannier66]

Not used at all?

[Miexil]

looks like a duplicate from line 4