Skip to content

Side panel, button dropdown and sidebar quick fixes - #718

Open
JulienVannier66 wants to merge 3 commits into
masterfrom
jv/vel-7000/oss-quick-fixes
Open

JulienVannier66 wants to merge 3 commits into
masterfrom
jv/vel-7000/oss-quick-fixes

Conversation

@JulienVannier66

Copy link
Copy Markdown
Contributor

What does this PR do?

Small design system fixes, one commit per ticket:

  • Side panel: OSS::SidePanel checks clicks against its own root element instead of the first .oss-side-panel in the document. With two side panels mounted (campaign Settings keeps a hidden tracking plan selector, then the duplicate campaign modal opens its own), a click inside the second panel was seen as outside and closed it.
  • Button dropdown: the OSS::ButtonDropdown menu clips its content (overflow: hidden), so the item hover background follows the rounded corners. Every current usage only renders simple rows, nothing needs to overflow the menu.
  • Sidebar: the menu shown when hovering a group of the collapsed sidebar gets a gray-200 border.

Related to:

What are the observable changes?

Visible in the apps once @upfluence/oss-components is released and bumped.

  • Workflow > campaign with a tracking plan > Settings > Settings > quick navigation > duplicate a campaign > enable "Track orders & Sales performances" > Select an existing tracking plan > click a plan's radio: the side panel stays open and the plan is selected.
  • Search > brand pre-made searches "…" menu: hovering the first or the last option shows a rounded hover background.
  • Collapsed sidebar: hovering a group shows its menu with a light gray border.

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation with Figma design link. Don't forget to replace "design" by "file" in the URL. For example https://www.figma.com/file/example
  • Migrated touched components to Glimmer Components
  • Properly labeled

@linear-code

linear-code Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

VEL-7000

VEL-7009

VEL-7132

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants