Repository navigation
Side panel, button dropdown and sidebar quick fixes - #718
Open
JulienVannier66 wants to merge 3 commits into
Open
JulienVannier66 wants to merge 3 commits into
JulienVannier66 wants to merge 3 commits into
Conversation
olxmpe
approved these changes
Oct 23, 2026
phndiaye
approved these changes
Oct 26, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Small design system fixes, one commit per ticket:
OSS::SidePanelchecks clicks against its own root element instead of the first.oss-side-panelin the document. With two side panels mounted (campaign Settings keeps a hidden tracking plan selector, then the duplicate campaign modal opens its own), a click inside the second panel was seen as outside and closed it.OSS::ButtonDropdownmenu clips its content (overflow: hidden), so the item hover background follows the rounded corners. Every current usage only renders simple rows, nothing needs to overflow the menu.gray-200border.Related to:
What are the observable changes?
Visible in the apps once
@upfluence/oss-componentsis released and bumped.Good PR checklist