fix: preserve whitespace in equals-form flag values - #2425
Open
BenYang12 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
What this PR does / why we need it:
parseFlagstrimmed the entire argument before extracting the value after=. Consequently,--text=" hello "became" hello"even withTrimSpace: false, while--text " hello "preserved the value.Extract the value from the original argument, keeping flag-name classification unchanged. Each flag's value parser now controls trimming and validation.
Which issue(s) this PR fixes:
Related to #2423, which inspired this investigation and fixed positional whitespace preservation, and #2169, which addressed string-slice trimming.
Testing
The regression tests fail in 25 cases with the original parser and all 60 cases pass with the fix. Coverage includes string, slice, and map flags; aliases; empty values; Unicode whitespace; embedded equals; and numeric/boolean validation.
Release Notes
Preserve whitespace in equals-form flag values, respecting each flag's trimming and validation rules. Numeric and boolean values with trailing whitespace now return parse
errors instead of being silently trimmed.