Skip to content

build(deploy): add Makefile target and go.mod/go.sum build triggers - #1170

Merged
cmainas merged 2 commits into
urunc-dev:main-pr1170from
Inuth0603:ci/urunc-deploy-trigger-paths
Nov 19, 2026
Merged

cmainas merged 2 commits into
urunc-dev:main-pr1170from
Inuth0603:ci/urunc-deploy-trigger-paths

Conversation

@Inuth0603

Copy link
Copy Markdown
Contributor

Update the urunc-deploy build workflow and add a Makefile target as follow-ups to #1102.

Changes

  • Add go.mod and go.sum to the paths in .github/workflows/build-trigger.yml so dependency changes trigger an image rebuild.
  • Add the urunc_deploy target and URUNC_DEPLOY_IMG variable to the Makefile to build the image from the repository root, passing COMMIT as a build arg.

Related issues

Refs #1096

How was this tested?

  • Ran make urunc_deploy locally on x86_64 with Docker and checked that urunc --version shows the commit.
  • Checked that make help displays the new target and URUNC_DEPLOY_IMG variable.

LLM usage

Google Gemini (via Antigravity) assisted with drafting the Makefile target and commit formatting. I reviewed and tested the changes locally.

Checklist

@netlify

netlify Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

👷 Deploy request for urunc pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 603f584

@cmainas cmainas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Inuth0603 for the PR,

Just a small comment that you can ignore for now. However, you need to rebase over main so we can merge.

Comment thread Makefile
## urunc_deploy Build the urunc-deploy container image for host arch.
.PHONY: urunc_deploy
urunc_deploy:
$(CNTR_TOOL) build \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also add one more parameter here to choose the architecture (. --platform), since Makefile already has this information and docker supports cross-arch builds.

Dependency updates change the urunc binary shipped in the urunc-deploy
image, but the build trigger ignored go.mod and go.sum. Add them to the
push paths so the image is rebuilt when dependencies change.

Signed-off-by: Divyam Agarwal <iitdivyamagarwal@gmail.com>
Add a urunc_deploy target that builds the urunc-deploy image from the
repository root for `linux/$(ARCH)` and passes COMMIT as a build-arg.
This avoids local builds that embed an empty commit in the urunc
version string.

Signed-off-by: Divyam Agarwal <iitdivyamagarwal@gmail.com>
@Inuth0603
Inuth0603 force-pushed the ci/urunc-deploy-trigger-paths branch from e7bcd65 to 603f584 Compare November 19, 2026 13:22
@Inuth0603

Copy link
Copy Markdown
Contributor Author

Hi @cmainas, thanks for the review. I've rebased on the latest main and added --platform linux/$(ARCH) to the urunc_deploy Makefile target. All CI checks are green now.

@urunc-bot
urunc-bot Bot changed the base branch from main to main-pr1170 November 19, 2026 13:49

@cmainas cmainas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Inuth0603

@cmainas
cmainas merged commit 541094c into urunc-dev:main-pr1170 Nov 19, 2026
36 checks passed
github-actions Bot pushed a commit that referenced this pull request Nov 19, 2026
Dependency updates change the urunc binary shipped in the urunc-deploy
image, but the build trigger ignored go.mod and go.sum. Add them to the
push paths so the image is rebuilt when dependencies change.

PR: #1170
Signed-off-by: Divyam Agarwal <iitdivyamagarwal@gmail.com>
Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
github-actions Bot pushed a commit that referenced this pull request Nov 19, 2026
Add a urunc_deploy target that builds the urunc-deploy image from the
repository root for `linux/$(ARCH)` and passes COMMIT as a build-arg.
This avoids local builds that embed an empty commit in the urunc
version string.

PR: #1170
Signed-off-by: Divyam Agarwal <iitdivyamagarwal@gmail.com>
Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
urunc-bot Bot pushed a commit that referenced this pull request Nov 19, 2026
Dependency updates change the urunc binary shipped in the urunc-deploy
image, but the build trigger ignored go.mod and go.sum. Add them to the
push paths so the image is rebuilt when dependencies change.

PR: #1170
Signed-off-by: Divyam Agarwal <iitdivyamagarwal@gmail.com>
Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
urunc-bot Bot pushed a commit that referenced this pull request Nov 19, 2026
Add a urunc_deploy target that builds the urunc-deploy image from the
repository root for `linux/$(ARCH)` and passes COMMIT as a build-arg.
This avoids local builds that embed an empty commit in the urunc
version string.

PR: #1170
Signed-off-by: Divyam Agarwal <iitdivyamagarwal@gmail.com>
Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants