Repository navigation
Merge External PR: Merge main-pr1202 into main - #1208
Merged
Merged
Conversation
The lint workflow moved to golangci-lint v2.15 with the Go v1.27.2 update in ee1476e, but the Makefile stayed at v2.9, which can't load a go1.27.3 module, so make lint stopped before linting. PR: #1202 Fixes: #1201 Signed-off-by: Martijn <martijn.hoekstra@kiteworks.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
The hvt and spt tenders take the same command line, and their BuildExecCmd bodies were identical, which dupl reported. Build it in one solo5ExecCmd. What is left of hvt.go and spt.go is the same thin wrapper, so dupl skips those two files. PR: #1202 Fixes: #1201 Signed-off-by: Martijn <martijn.hoekstra@kiteworks.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Statfs_t.Flags is an int64 on amd64 and arm64, and the ST_* constants are untyped, so keep them as int64 instead of converting the flags to uintptr, which gosec reported as G115. PR: #1202 Fixes: #1201 Signed-off-by: Martijn <martijn.hoekstra@kiteworks.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
runcExec hands non-unikernel containers to runc with urunc's own arguments, and prepareXDGRuntimeDir only creates $XDG_RUNTIME_DIR/urunc for a rootless user, so G702 and G703 do not apply there. PR: #1202 Fixes: #1201 Signed-off-by: Martijn <martijn.hoekstra@kiteworks.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
✅ Deploy Preview for urunc canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was automatically created by GitHub Actions to merge changes from main-pr1202 into main.