Skip to content

Merge External PR: Merge main-pr1202 into main - #1208

Merged
urunc-bot[bot] merged 4 commits into
mainfrom
main-pr1202
Nov 16, 2026
Merged

urunc-bot[bot] merged 4 commits into
mainfrom
main-pr1202

Conversation

@urunc-bot

@urunc-bot urunc-bot Bot commented Nov 16, 2026

Copy link
Copy Markdown

This PR was automatically created by GitHub Actions to merge changes from main-pr1202 into main.

The lint workflow moved to golangci-lint v2.15 with the Go v1.27.2
update in ee1476e, but the Makefile stayed at v2.9, which can't load a
go1.27.3 module, so make lint stopped before linting.

PR: #1202
Fixes: #1201
Signed-off-by: Martijn <martijn.hoekstra@kiteworks.com>
Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
The hvt and spt tenders take the same command line, and their
BuildExecCmd bodies were identical, which dupl reported. Build it in one
solo5ExecCmd. What is left of hvt.go and spt.go is the same thin wrapper,
so dupl skips those two files.

PR: #1202
Fixes: #1201
Signed-off-by: Martijn <martijn.hoekstra@kiteworks.com>
Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Statfs_t.Flags is an int64 on amd64 and arm64, and the ST_* constants
are untyped, so keep them as int64 instead of converting the flags to
uintptr, which gosec reported as G115.

PR: #1202
Fixes: #1201
Signed-off-by: Martijn <martijn.hoekstra@kiteworks.com>
Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
runcExec hands non-unikernel containers to runc with urunc's own
arguments, and prepareXDGRuntimeDir only creates $XDG_RUNTIME_DIR/urunc
for a rootless user, so G702 and G703 do not apply there.

PR: #1202
Fixes: #1201
Signed-off-by: Martijn <martijn.hoekstra@kiteworks.com>
Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
@urunc-bot
urunc-bot Bot merged commit c408b87 into main Nov 16, 2026
@netlify

netlify Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for urunc canceled.

Name Link
🔨 Latest commit 47b0b71
🔍 Latest deploy log https://app.netlify.com/projects/urunc/deploys/6afb2282f985d37f16583240

@urunc-bot
urunc-bot Bot deleted the main-pr1202 branch November 16, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant