Repository navigation
Merge External PR: Merge main-pr1170 into main - #1213
Merged
Merged
Conversation
Dependency updates change the urunc binary shipped in the urunc-deploy image, but the build trigger ignored go.mod and go.sum. Add them to the push paths so the image is rebuilt when dependencies change. PR: #1170 Signed-off-by: Divyam Agarwal <iitdivyamagarwal@gmail.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Add a urunc_deploy target that builds the urunc-deploy image from the repository root for `linux/$(ARCH)` and passes COMMIT as a build-arg. This avoids local builds that embed an empty commit in the urunc version string. PR: #1170 Signed-off-by: Divyam Agarwal <iitdivyamagarwal@gmail.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
✅ Deploy Preview for urunc canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was automatically created by GitHub Actions to merge changes from main-pr1170 into main.