Repository navigation
test(unikernels): add unit tests for New, subnetMaskToCIDR, and createFile - #1215
Open
AbdullahZulfiqar2005 wants to merge 1 commit into
Open
AbdullahZulfiqar2005 wants to merge 1 commit into
AbdullahZulfiqar2005 wants to merge 1 commit into
Conversation
…eFile Signed-off-by: Abdullah Zulfiqar <abdullahzulfiqar580@gmail.com>
👷 Deploy request for urunc pending review.Visit the deploys page to approve it
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds table-driven unit tests for previously uncovered functions in pkg/unikontainers/unikernels:
unikernel_test.go (New): Verifies concrete types returned for all 7 supported unikernels (rumprun, unikraft, mirage, mewz, linux, hermit, freebsd) and verifies ErrNotSupportedUnikernel for empty, unknown, and mismatched-case inputs (0.0% → 100.0% coverage).
utils_test.go (subnetMaskToCIDR, createFile): Covers standard and non-octet subnet masks (/0, /8, /16, /20, /24, /32), malformed/out-of-range mask errors (81.8% → 100.0% coverage), plus file creation, overwrite, and missing parent directory errors using t.TempDir() (0.0% → 87.5% coverage).
Overall pkg/unikontainers/unikernels statement coverage increases from 32.7% to 38.6%.
Related issues
How was this tested?
Ran unit tests with race detection, coverage, formatting, and vet locally:
gofmt -l pkg/unikontainers/unikernels/unikernel_test.go pkg/unikontainers/unikernels/utils_test.go go vet ./pkg/unikontainers/unikernels/... go test -v -race -coverprofile=/tmp/urunc_cov.out ./pkg/unikontainers/unikernels/... go tool cover -func=/tmp/urunc_cov.outAll tests pass with zero data races.
LLM usage
Assisted by gemini 4 neon for drafting the initial table-driven test cases and reviewing coverage; all test cases were reviewed, formatted, and verified locally.
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).