feat: implementa leitura de eventos - #541
Merged
Merged
Conversation
EduTiyo
requested changes
Sep 21, 2026
EduTiyo
left a comment
There was a problem hiding this comment.
Revisão em duas frentes (Standards e Spec) da leitura de Eventos. A busca por id (BuscarEventoController) está correta e, inclusive, evita o bug de mapeamento de erro que peguei no PR do Jordan (#540) — separa falha de infra (500) de "não encontrado" (404), parabéns por isso. Mas a listagem entrega só o roteamento: os três pedidos centrais do spec — paginação (?limite/?pagina), os filtros já existentes em EventoFilters (tipo, capturado_de, capturado_ate) e a ordenação estável (capturado_em desc, id desc, chamada de "a parte difícil" no combinado do time) — não chegam a ser usados. Falta também cobertura de integração para as duas rotas novas.
EduTiyo
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
O que foi feito
Implementados os endpoints de leitura de Eventos da API v2:
GET /api/v2/expedicoes/:expedicaoId/eventosGET /api/v2/eventos/:eventoIdImplementação
create-app.ts.EventoCollectionKnexAdapterexistente.expedicaoIdeeventoId.Testes
yarn run test:unit: 79 testes passando.yarn run tsc:check: concluído com sucesso.yarn run lint:eslint: concluído com sucesso.