Skip to content

chore: require Validators ^1.0 - #963

Merged
abnegate merged 1 commit into
mainfrom
chore/validators-1
Sep 10, 2026
Merged

chore: require Validators ^1.0#963
abnegate merged 1 commit into
mainfrom
chore/validators-1

Conversation

@ChiragAgg5k

@ChiragAgg5k ChiragAgg5k commented Sep 10, 2026

Copy link
Copy Markdown
Member

Summary

Require Validators ^1.0 exclusively. No aliases or fallback ranges.

Upgrade the development CLI requirement to ^0.24.4: CLI 0.22 pins Servers 0.2, which still requires Validators 0.x and prevents installing the development graph. Refresh the tracked lockfile minimally: Validators 1.0.1, CLI 0.24.4, Servers 0.4.11.

Prerequisite for appwrite/appwrite#13575 and https://github.com/appwrite-labs/cloud/pull/5734. Validators 1.0 changes Assoc's declared type from array to object; this does not add a compatibility override. A Database release is needed after merge before Audit/CE/Cloud can resolve.

Verification

PHP 8.5.10 with released Validators 1.0.1:

  • composer update utopia-php/validators utopia-php/cli --with-all-dependencies --minimal-changes --ignore-platform-reqs --no-interaction --no-progress: passed.
  • XDEBUG_MODE=off php -d memory_limit=1G vendor/bin/phpunit --testsuite unit: 469 tests / 2,408 assertions passed. Existing ReflectionProperty deprecations emitted on PHP 8.5.
  • XDEBUG_MODE=off composer check: passed across 155 files.
  • composer lint, composer validate --no-check-publish, git diff --check: passed.
  • Database-engine E2E and downstream application tests were not run. Backend-only; no screenshots apply.
  • composer audit still reports PKSA-61k5-cqr9-b8b4 on unchanged mongodb/mongodb. This PR does not fix that advisory.

No releases or deployments performed.

Summary by CodeRabbit

  • Chores
    • Updated internal package requirements to support newer tooling and validation capabilities.
    • No user-facing features, behavior changes, or interface updates are included in this release.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 71c1f192-55ef-44e8-a9b0-414c3137cfd8

📥 Commits

Reviewing files that changed from the base of the PR and between a81a256 and 6ffe202.

⛔ Files ignored due to path filters (1)
  • composer.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • composer.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The pull request updates the composer.json constraints for utopia-php/validators and utopia-php/cli.

Changes

Dependency updates

Layer / File(s) Summary
Update Composer constraints
composer.json
The utopia-php/validators requirement changes to ^1.0. The utopia-php/cli development requirement changes to ^0.24.4.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: abnegate

Merge Risk: 🔵 Low · up to 6ffe2

Validators 1.0.1 introduces an Assoc type change that requires coordinated Database and downstream releases. The dependency update is otherwise validated and mergeable with that follow-up.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the primary change: requiring utopia-php/validators ^1.0. It is concise and related to the dependency updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/validators-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

The PR appears safe to merge, with a non-blocking gap in behavioral coverage for the upgraded development CLI commands.

Fix All in Claude CodeFindings

  1. P2 CLI Behavior Lacks Coverage
Fix with agent prompt
### Issue 1
composer.json:52
This upgrade changes the runtime dependency used by `bin/cli.php` and every `bin/tasks/*` command, including task registration and error injection. The reported unit and static-analysis checks do not exercise those entrypoints, so they cannot detect a CLI API or dependency-injection regression. Add an observable command-level smoke test rather than asserting package versions or configuration.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

  • Requires utopia-php/validators ^1.0, resolving to 1.0.1.
  • Requires utopia-php/cli ^0.24.4, resolving to CLI 0.24.4, Servers 0.4.11, and DI 0.3.6.
  • Leaves a non-blocking behavioral coverage gap for the repository’s CLI entrypoints.

Reviews (1) · Last reviewed commit: "chore: require Validators ^1.0"

Comment thread composer.json
@abnegate
abnegate merged commit 5592a23 into main Sep 10, 2026
22 checks passed
@abnegate
abnegate deleted the chore/validators-1 branch September 10, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants