chore: require Validators ^1.0 - #963
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe pull request updates the ChangesDependency updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Merge Risk: 🔵 Low · up to Validators 1.0.1 introduces an Assoc type change that requires coordinated Database and downstream releases. The dependency update is otherwise validated and mergeable with that follow-up. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Summary
Require Validators
^1.0exclusively. No aliases or fallback ranges.Upgrade the development CLI requirement to
^0.24.4: CLI 0.22 pins Servers 0.2, which still requires Validators 0.x and prevents installing the development graph. Refresh the tracked lockfile minimally: Validators 1.0.1, CLI 0.24.4, Servers 0.4.11.Prerequisite for appwrite/appwrite#13575 and https://github.com/appwrite-labs/cloud/pull/5734. Validators 1.0 changes
Assoc's declared type from array to object; this does not add a compatibility override. A Database release is needed after merge before Audit/CE/Cloud can resolve.Verification
PHP 8.5.10 with released Validators 1.0.1:
composer update utopia-php/validators utopia-php/cli --with-all-dependencies --minimal-changes --ignore-platform-reqs --no-interaction --no-progress: passed.XDEBUG_MODE=off php -d memory_limit=1G vendor/bin/phpunit --testsuite unit: 469 tests / 2,408 assertions passed. Existing ReflectionProperty deprecations emitted on PHP 8.5.XDEBUG_MODE=off composer check: passed across 155 files.composer lint,composer validate --no-check-publish,git diff --check: passed.composer auditstill reportsPKSA-61k5-cqr9-b8b4on unchangedmongodb/mongodb. This PR does not fix that advisory.No releases or deployments performed.
Summary by CodeRabbit