Skip to content

introduce static mut IS_POSIXLY_CORRECT - #11939

Closed
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:static-posixly-correct3
Closed

introduce static mut IS_POSIXLY_CORRECT#11939
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:static-posixly-correct3

Conversation

@xtqqczze

Copy link
Copy Markdown
Contributor

No description provided.

@xtqqczze
xtqqczze force-pushed the static-posixly-correct3 branch 2 times, most recently from 9cc75ba to 5f3a2aa Compare April 22, 2026 00:27
@github-actions

github-actions Bot commented Apr 22, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/retry (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/misc/io-errors (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/seq/seq-epipe is now passing!
Congrats! The gnu test tests/tail/pipe-f is now passing!
Note: The gnu test tests/env/env-signal-handler was skipped on 'main' but is now failing.

@xtqqczze
xtqqczze force-pushed the static-posixly-correct3 branch from 5f3a2aa to 067520d Compare April 22, 2026 13:57
@RenjiSann

Copy link
Copy Markdown
Collaborator

Why would you introduce so much unsafe here ? Is it motivated by a significant gain in performance ?

@xtqqczze
xtqqczze force-pushed the static-posixly-correct3 branch from 067520d to de2ca92 Compare April 23, 2026 20:06
@codspeed-hq

codspeed-hq Bot commented Apr 23, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 367 untouched benchmarks
⏩ 50 skipped benchmarks1


Comparing xtqqczze:static-posixly-correct3 (339547e) with main (4bae306)2

Open in CodSpeed

Footnotes

  1. 50 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (a5d6966) during the generation of this report, so 4bae306 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@xtqqczze xtqqczze changed the title cp: introduce static mut IS_POSIXLY_CORRECT introduce static mut IS_POSIXLY_CORRECT Apr 23, 2026
@xtqqczze
xtqqczze force-pushed the static-posixly-correct3 branch from de2ca92 to 6dc2b99 Compare April 23, 2026 20:50
@xtqqczze
xtqqczze force-pushed the static-posixly-correct3 branch from 6dc2b99 to 339547e Compare September 12, 2026 22:07
@xtqqczze

xtqqczze commented Sep 12, 2026

Copy link
Copy Markdown
Contributor Author

These changes are not correct, as we have entry points other than uumain, such as uu_cp::copy.

@xtqqczze xtqqczze closed this Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants