nohup: move platform code into platform/{unix,windows}.rs - #14525
Open
sylvestre wants to merge 1 commit into
Open
nohup: move platform code into platform/{unix,windows}.rs#14525sylvestre wants to merge 1 commit into
sylvestre wants to merge 1 commit into
Conversation
Instead of scattering #[cfg(unix)] / #[cfg(windows)] through nohup.rs, keep the platform-specific code in its own file behind a small shared interface: prepare(), run() and set_output_file_mode(). The unix-only CannotDetach/CannotReplace variants move to a unix PlatformError, so NohupError in nohup.rs is now platform independent.
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Refactors nohup to centralize platform-specific behavior behind a shared interface (prepare(), run(), set_output_file_mode()), reducing scattered #[cfg(...)] blocks and making nohup.rs platform-independent.
Changes:
- Adds new Unix and Windows platform modules implementing a common interface.
- Moves Unix-only detach/FD-replace failures into a Unix
PlatformErrorsoNohupErrorstays platform-agnostic. - Updates
nohup.rsto delegate platform behavior toplatform::*.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/uu/nohup/src/platform/windows.rs | Introduces Windows-specific prepare/run/set_output_file_mode implementation. |
| src/uu/nohup/src/platform/unix.rs | Introduces Unix-specific detach, fd replacement, and output-file-mode logic with Unix-only errors. |
| src/uu/nohup/src/nohup.rs | Switches to platform modules and removes embedded platform-specific logic/errors. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| command.stdout(find_stdout()?); | ||
| } | ||
| if std::io::stderr().is_terminal() { | ||
| command.stderr(Stdio::inherit()); |
Contributor
There was a problem hiding this comment.
I was misunderstanding what replace_fds do at my PR. Can we reuse a let nohup_out = find_stdout()?
| pub(crate) fn prepare() -> UResult<()> { | ||
| replace_fds()?; | ||
|
|
||
| unsafe { libc::signal(libc::SIGHUP, libc::SIG_IGN) }; |
Comment on lines
+33
to
+38
| if std::io::stdout().is_terminal() { | ||
| command.stdout(find_stdout()?); | ||
| } | ||
| if std::io::stderr().is_terminal() { | ||
| command.stderr(Stdio::inherit()); | ||
| } |
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of scattering #[cfg(unix)] / #[cfg(windows)] through nohup.rs, keep the platform-specific code in its own file behind a small shared interface: prepare(), run() and set_output_file_mode().
The unix-only CannotDetach/CannotReplace variants move to a unix PlatformError, so NohupError in nohup.rs is now platform independent.