Repository navigation
feat(cli): prepare and submit connector PRs (BUI-942) - #133
Draft
callumflack wants to merge 5 commits into
Draft
callumflack wants to merge 5 commits into
callumflack wants to merge 5 commits into
Conversation
BUI-942 Assisted-by: AI Signed-off-by: Callum Flack <749885+callumflack@users.noreply.github.com>
BUI-942 Assisted-by: AI Signed-off-by: Callum Flack <749885+callumflack@users.noreply.github.com>
BUI-942 BUI-952 Assisted-by: AI Signed-off-by: Callum Flack <749885+callumflack@users.noreply.github.com>
BUI-942 Assisted-by: AI Signed-off-by: Callum Flack <749885+callumflack@users.noreply.github.com>
BUI-942 Assisted-by: AI Signed-off-by: Callum Flack <749885+callumflack@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builders can prepare and submit a new PDP-Connect connector or an improvement using Vana CLI.
prepare-prpreviews one signed-off connector commit and its review evidence.submit-prchecks the builder's GitHub identity, requires confirmation of that exact public preview, pushes to their existing public fork and opens a draft PR.The public review pack carries the checked commit, environment, exact commands, exit statuses and output, plus a reviewed synthetic input and resulting record. Updates also show the previous output and describe effects on existing records, IDs and cursors. Older summaries remain previewable with explicit gaps. Submission requires the complete initial pack. The bundled Create Connector instructions include the schema and submission steps.
New connector submissions can include the required upstream registration and generated files. Validation checks that the added entries belong to the selected connector, the generated credential and consent entries match its manifest, and the manifest count increases by one. The rest of each shared file is preserved.
Recovery contract. GitHub can create a PR even when the CLI loses the response. Retry looks up the stable account/commit branch before any push or creation. Tests record every write attempt and require zero additional writes when recovering the same PR.
Evidence
Verified at
ecdd089583c1d238c440385bf42c78353d17b3e1on Node 24.22.1, macOS../node_modules/.bin/vitest runexited 0. All 1,165 tests in 80 files passed.11df55e39e6f7cb7f5c4651ff2b93987e3a3ba76, plus TypeScript, ESLint, formatting and build.540d34e7b3ebaa8fcb62c7bc92a2ee360c0b9945using the builder’s GitHub account. The identical confirmed retry returned #642 withreused: true. The transport allowed GitHub reads only and recorded zero push or write attempts.Release gate
Tim accepted starting with this review format on 11 November and confirmed the flow should submit new connectors. The evidence format can evolve with use.
This PR remains draft. The live CLI submission and recovery are verified through Readwise #642. Before shipping, complete review, merge, signing and publication proof, and settle the operating owners and release handoff in BUI-952. App availability needs its own proof wherever reported.
BUI-942 · BUI-952