Repository navigation
fix(runtime): give a desktop app's shells a temp folder of their own - #65
Merged
Merged
Conversation
…64) * fix(runtime): give a desktop app's shells a temp folder of their own zsh writes here-docs under /tmp/zsh, which the confinement denies: VS Code's shell (read at its start, and its terminal's integration) said "can't create temp file" on camera. TMPPREFIX now points into the sandbox's temp for every desktop app. With KIFRAME_ELECTRON_DEBUG, the app's own output and exit code are written to Kiframe's stderr (how VS Code's silent quit was found). * fix(scripts): give real-app runs a short work folder An app's socket in its sandbox must fit macOS's 104 characters: VS Code quit at once under the run's own output folder. Runs use /tmp/kf-*, removed at exit; the Check outcomes "quit" and "the site" end the wait too. * docs(backlog): record the VS Code pass and its open items Socket path length (stated limit), shell temp files (fixed), grounding in an editor, and two items left for a reviewed design: a desktop take refused when the window is smaller than its viewport, and the guard's way back from a site.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #64 (merged by mistake into #63's branch, never into the epic): the same commit, cherry-picked onto the epic. The VS Code real-app pass, its safe fixes only.
Found on confined VS Code
~/.kiframe(95 here): a stated limit (BACKLOG, FAILURE-CATALOGUE feat(compositor): draw the background image in the preview and the export #25). The driver now uses a short/tmp/kf-*work folder./tmp/zsh, denied.TMPPREFIXnow points into the sandbox temp for every desktop app (feat(desktop): show the agent thinking among its steps, then for how long #27; a fixture probe, fails with the fix taken out).KIFRAME_ELECTRON_DEBUG, the app's own output and exit code go to Kiframe's stderr (how the quit was found).Left for a reviewed design (BACKLOG)
Verified
Kif on confined VS Code opened the demo folder,
greet.ts, rancat package.jsonin its terminal (neutral prompt), recorded once full screen.pnpm checkgreen.