Repository navigation
fix(sdk): Pg0.start() no longer hangs on Linux/macOS - #48
Merged
Merged
Conversation
Use the temp-file stdio path on every platform, not just Windows. Fixes #45.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45.
pg0 startspawns PostgreSQL, which inherits pg0's stdout/stderr. On Linux/macOS the SDK captured them with pipes, so when a child kept the pipe open,subprocess.runwaited forever even though pg0 had exited. The Windows branch already avoided this by writing to temp files. This uses that path on every platform and keeps the Windows-onlyCREATE_NO_WINDOWflag.Test:
test_runner_does_not_wait_for_children_holding_stdiouses a fakepg0that leaves asleep 30child holding stdout. It takes 30s and fails onmain, and passes in 0.3s with this change.