Fix issue in algorithm of hash computing for EncryptionToolsRevision5_6

[LonelyMidoriya]

Summary by CodeRabbit

• Chores
  • No user-visible changes are included in this update.
  • PDF 2.0 revision 6+ encryption hash processing remains behaviorally unchanged, including computed key hashes and loop termination.
  • No end-user capabilities were added, removed, or altered.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 4f839a64-924a-4d67-87fc-4744c72c1c81

📥 Commits

Reviewing files that changed from the base of the PR and between 6fa1b1a and 4aabf1d.

📒 Files selected for processing (1)

• src/main/java/org/verapdf/tools/EncryptionToolsRevision5_6.java

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The revision 6 hash computation loop now starts rounds at 1. Its break condition uses rounds >= 64 and rounds - 32, preserving the prior iteration behavior.

Changes

Revision 6 hash computation

Layer / File(s)	Summary
Hash loop counter and termination alignment src/main/java/org/verapdf/tools/EncryptionToolsRevision5_6.java	The loop initializes rounds to 1. The break condition now uses rounds >= 64 and compares the final byte with rounds - 32.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 4aabf

The revision 6 hash computation remains behaviorally aligned, so encrypted-document authentication has no identified merge-blocking regression.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: fixing the hash computation algorithm in EncryptionToolsRevision5_6. It is specific and related to the two-line algorithm correction.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch encryption-tools-5-6

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}