Skip to content

skills(vercel-flags): follow repo rules and check overlap in flag cleanup - #584

Merged
luismeyer merged 1 commit into
mainfrom
luis/flags-cleanup-repo-rules
Oct 30, 2026
Merged

luismeyer merged 1 commit into
mainfrom
luis/flags-cleanup-repo-rules

Conversation

@luismeyer

Copy link
Copy Markdown
Member

Two owners rewrote the Vercel Agent cleanup PRs for vercel/front (for example front#94746). The diffs were right, but the agent added a kind of test the repo doesn't allow, ignored the repo's PR template, and linked the flag to the wrong URL. It also skipped checks that the internal dead-flag cleanup runs. This updates references/cleanup.md so agents follow the repository and check for collisions:

  • Follow the repository's rules: a new first section. Read AGENTS.md, CLAUDE.md, contributing guides, flag-removal guides, and the PR template; where they differ from this reference, follow the repository.
  • Evidence: search the fetched default branch, not a stale local one. Look for open PRs by other authors on the flag's call sites.
  • When to stop: also stop when a description or code comment says to keep the flag, or when another author's open, non-draft PR updated in the last two weeks changes the same lines.
  • Tests: prefer updating existing tests, and don't add a kind of test the repo's guidelines rule out.
  • Checks: if a check can't run, for example because dependencies fail to install, name it in the PR with the reason.
  • PR: use the repo's template and title conventions. The flag link is https://vercel.com/<team-slug>/<project-name>/flag/<key>, with slugs, not IDs.

SKILL.md: the References entry now mentions the repository rules.

🤖 Generated with Claude Code

…anup

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
flags-playground Ready Ready Preview, v0 Oct 30, 2026 9:49am UTC
flags-sdk-dev Ready Ready Preview, v0 Oct 30, 2026 9:49am UTC
flags-sdk-flagsmith Ready Ready Preview, v0 Oct 30, 2026 9:49am UTC
flags-sdk-growthbook Ready Ready Preview, v0 Oct 30, 2026 9:49am UTC
flags-sdk-launchdarkly Ready Ready Preview, v0 Oct 30, 2026 9:49am UTC
flags-sdk-openfeature Ready Ready Preview, v0 Oct 30, 2026 9:49am UTC
flags-sdk-posthog Ready Ready Preview, v0 Oct 30, 2026 9:49am UTC
flags-sdk-reflag Ready Ready Preview, v0 Oct 30, 2026 9:49am UTC
flags-sdk-snippets Ready Ready Preview, v0 Oct 30, 2026 9:49am UTC
flags-sdk-statsig Ready Ready Preview, v0 Oct 30, 2026 9:49am UTC
flags-sdk-sveltekit-snippets Ready Ready Preview, v0 Oct 30, 2026 9:49am UTC
shirt-shop Ready Ready Preview, v0 Oct 30, 2026 9:49am UTC
shirt-shop-api Ready Ready Preview, v0 Oct 30, 2026 9:49am UTC

@luismeyer
luismeyer merged commit c9a11d5 into main Oct 30, 2026
30 checks passed
@luismeyer
luismeyer deleted the luis/flags-cleanup-repo-rules branch October 30, 2026 12:01

This branch was successfully deployed

14 active deployments
Preview – flags-sdk-dev — c03ec291 Deployed Oct 30, 2026 by vercel[bot]
Preview – flags-sdk-sveltekit-snippets — c03ec291 Deployed Oct 30, 2026 by vercel[bot]
Preview – flags-playground — c03ec291 Deployed Oct 30, 2026 by vercel[bot]
Preview – flags-sdk-snippets — c03ec291 Deployed Oct 30, 2026 by vercel[bot]
Preview – flags-sdk-launchdarkly — c03ec291 Deployed Oct 30, 2026 by vercel[bot]
Preview – flags-sdk-posthog — c03ec291 Deployed Oct 30, 2026 by vercel[bot]
Preview – flags-sdk-growthbook — c03ec291 Deployed Oct 30, 2026 by vercel[bot]
Preview – flags-sdk-vercel — c03ec291 Deployed Oct 30, 2026 by vercel[bot]
Preview – flags-sdk-reflag — c03ec291 Deployed Oct 30, 2026 by vercel[bot]
Preview – flags-sdk-flagsmith — c03ec291 Deployed Oct 30, 2026 by vercel[bot]
Preview – flags-sdk-statsig — c03ec291 Deployed Oct 30, 2026 by vercel[bot]
Preview – shirt-shop-api — c03ec291 Deployed Oct 30, 2026 by vercel[bot]
Preview – flags-sdk-openfeature — c03ec291 Deployed Oct 30, 2026 by vercel[bot]
Preview – shirt-shop — c03ec291 Deployed Oct 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants