Repository navigation
chore: sync main back into development after v1.15.0 - #506
Merged
Merged
Conversation
release: v1.15.0 — the export gets a phase breakdown, and four rounds of C-343 land (#501)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MERGE COMMIT ONLY — never squash, never rebase
A squash creates yet another commit that is not
main, somainstill would not be an ancestor ofdevelopmentand this PR would have to be opened again. That is not a style preference: it is thefailure this PR exists to repair, and squashing it reopens it.
Why this exists
Promoting
development→mainthrough a PR (#504) leaves a merge commit onmainthatdevelopmenthas never seen:One commit, always exactly one, every release. Expected immediately after a release and a problem
only if it persists — so this PR is the last step of the v1.15.0 release, not a separate task.
Left unhealed the divergence accumulates:
git log main..developmentstarts counting work thatalready shipped, and the next release's diff begins from a base that no longer reflects reality.
This step was skipped after every release before v1.10.0.
What is currently red because of it
Both are real failures, not cosmetic, and both go green when this merges:
TestF2ReleaseTopology::test_main_is_ancestor_of_developmenttests/test_falsification_deploy_v160.py:159TestDF1MergeTopology::test_main_ancestor_of_developmenttests/test_falsification_deploy_v160_r2.py:50Release hygieneworkflowThe two tests carry their own remedy in the assertion message, which is why this was expected rather
than investigated.
v1.15.0 release state
development7cef97fmainas a merge commitb0c0b17v1.15.0b0c0b173a, same commit asorigin/maintest_version_equals_the_tag_head_is_onPublish Packageviews-datafactory 1.15.0uv pip install views-datafactory==1.15.0)1.15.0; all ninedatafactory_*packages importserver_quickref.md, still pendingThe clean-venv check is the guide's requirement — verify by installing the published artifact, not by
reading a green tick. Worth recording how it first failed: a venv built on Python 3.10.14 reported
No matching distribution foundagainstrequires-python = ">=3.11". The broken thing was thecheck, not the release, and a less careful reading of that message would have looked like a failed
publish.
Refs #501, #505.
🤖 Generated with Claude Code
https://claude.ai/code/session_01EfeuULbPTqrx4qtNki5dy9