Conversation
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
This was referenced Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Initial JS currently includes chunks reached only through dynamic imports. For example, an entry that statically imports a framework and dynamically imports a chart counts the chart as initial too.
Follow only static imports from user-defined entries, and recompute
is_initialwhen restoring cached snapshots so existing traces receive the correction without rebuilding.Linked Issues
None.
Additional context
Adds five regression tests covering dynamic-only subtrees, cycles, multiple entries, chunks shared by static and dynamic paths, and older snapshots. The traversal and snapshot tests fail without the fix.
Validation:
pnpm lint,pnpm build, andpnpm test --runpassed (347 passed, 2 skipped).pnpm typecheckreports the same eight existing Nuxt/Vite plugin type errors on both unmodified59260bfdand this branch, in the Oxc, Rolldown, and Vitesrc/modules/rpc.tsfiles.