Conversation
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Opening plugin details on a large Rolldown trace can exhaust the heap: hydration reads every plugin's hook events before filtering, then resolves all transform contents together.
Read indexed hooks in batches of up to 128 calls and 1 MiB of source event bytes, retaining only the requested plugin's metrics. Compare transform contents in groups of up to 128 calls so event payloads and resolved strings can be released between groups. An oversized hook is read alone; this bounds bulk reads rather than imposing a total heap limit.
Linked Issues
None.
Additional context
Adds five regression cases covering call and byte limits, oversized hooks, filtering and ordering across modules, transform equality, and string references with missing index entries. All five fail on the previous implementation and pass with this change. Reader cache eviction is unchanged.
Validation:
pnpm lint,pnpm build, andpnpm test --runpassed (347 passed, 2 skipped).pnpm typecheckreports the same eight existing Nuxt/Vite plugin type errors as unmodified59260bfd, in the Oxc, Rolldown, and Vitesrc/modules/rpc.tsfiles.