Conversation
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Please take a moment to read this. Thank you!
I should include a brief explanation of the problem in my own words in every PR. If that explanation is missing, please @mention me and do not merge this PR until I have added it. You may also leave this PR unaddressed (because this means I have not fulfilled my responsibilities as the author).
If my explanation is unclear or difficult to follow, please ask me to clarify or provide reproduction steps or supporting evidence.
I welcome suggestions and counterarguments, especially questions about anything I may have overlooked. (Your feedback helps me learn and improve. 🙏)
I hold myself to this standard for every PR, regardless of its size.
Summary
When I run Format Inspector without an Oxfmt config, Oxfmt 0.70.0 prints a defaults notice to stderr. A clean check or successful write exits with code 0, but DevTools throws
OXDT0007and discards the result. In write mode, the file has already been formatted even though the UI reports failure.Classify the command result using its exit code and parsed status before saving it. Successful runs and check-mode formatting findings are saved even when stderr contains a notice. Execution failures still produce
OXDT0007, using stderr or an exit-code fallback when stderr is empty.Evidence
Formattedresult, and a clean check saves aPassedresult.pnpm lint,pnpm build --force, andpnpm test --runpass (351 tests passed, 2 skipped).pnpm typecheckreports 8 existing Vite plugin type errors in the Oxc, Rolldown, and Vite RPC modules. Re-running with both changed files restored to the upstream baseline produces identical errors.Merge Danger
Door: Two-way. No persisted result schema changes.
Blast Radius: Oxfmt. Changes command-result classification in Format Inspector.