Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In a build,
src/rsc/shared.tsresolves a server reference withserverReferences[id]. Two things make an unknown id hard for a framework to handle:Object.prototypemembers do not reach the not-found branch:constructor"loads" (it calls the inheritedObjectconstructor), and__proto__orhasOwnPropertythrow aTypeErrorfromimport_(). A request that only names an unknown id should always get the not-found error.server reference not found '<id>', after stripping the$$cache=tag the same wayremoveReferenceCacheTagdoes.This PR looks the id up with
Object.hasOwnand gives the not-found error a stablecode: 'VITE_RSC_SERVER_REFERENCE_NOT_FOUND'. The message is unchanged, so anything matching on it keeps working.Scope: the build path only. In dev, an unknown id is rejected earlier by the
rsc:reference-validationplugin with its own error; I left that alone, since it already fails loudly. Happy to add the same code there if you want both paths to match.Tests: this runtime file has no unit test harness, and I could not run the e2e suite in my environment. I checked the lookup logic in isolation (known id, missing id,
__proto__,constructor,hasOwnProperty), and we run this exact change as a local patch in our framework's CI in the meantime. If you'd like an e2e case, point me to the fixture you prefer and I'll add one.Related: #1337 and #1346 (route-aware server reference metadata). A has-reference check could come out of that work; this PR only makes the existing not-found error reliable and recognizable.