Conversation
Expose compact schema discovery and generic JSON bodies and file downloads so agents can complete reviews using server contracts. Preserve JSON output and dedicated review retry behavior.
Open the exclusive destination before transferring bytes so early stream failures cannot leave an empty file behind. Exercise credential precedence, refresh/replay behavior, binary errors and cleanup through real CLI subprocesses and HTTP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents can use the existing API command to query Vizzly, but discovering endpoints requires outside documentation, POST is limited to comments, and responses are always parsed as JSON. Those restrictions prevent a complete schema-driven visual review.
Add operation discovery through
vizzly api schema, with compact request instructions and optional fields/response/full schema views. Extend generic requests with JSON file/stdin bodies and explicit file output for images. Preserve the existing JSON envelope and prefer a user login over an implicit linked upload token, while honoring explicit credentials. Schema discovery works before login. Requests reject redirects, downloads do not overwrite files and remove partial output even when a stream fails before its first byte, and generic writes are not automatically replayed; existing idempotent review-command retries remain intact.The CLI regression suite, lint/format, type checks, and production build pass. Real subprocess/HTTP tests cover discovery, bodies, interrupted downloads, empty/error responses, redirects, login versus explicit credential precedence, read refresh, and suppression of mutation replays. The packed candidate also completed a schema-discovered review against a real API: paged captures/comparisons, image downloads, decisions, and persisted-state verification.
Schema lookup requires a server exposing the new discovery endpoints. The existing raw API invocation and JSON wrapping remain supported. No endpoint-specific capability flags, offline schema cache, or new query language are introduced.