Repository navigation
test: count the Awards footer link in the privacy and terms e2e suites - #147
officialasishkumar wants to merge 1 commit into
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
The Awards link from vycdev#126 added an eighth link to the landing footer. The narrow-screen footer tests in privacy.spec.ts and terms.spec.ts still expected seven, so `npm run test:e2e:privacy` and `npm run test:e2e:terms` failed all four width/theme cases on develop, and their CI jobs failed on every pull request. These suites have their own Playwright configs, so the i18n footer fix in vycdev#137 did not reach them. - Expect eight footer links in both tests. Every link, Awards included, is still checked to be fully in the viewport, at least 44px tall, above the sticky launch bar, and not covered at its centre. - The privacy test tabbed once from "Support Kromacut" and expected Privacy to take focus. Awards now opens the utility row, so assert that Tab reaches Awards first and Privacy on the next Tab, keeping the keyboard-order check instead of skipping over the new link. - The terms test tabs from Privacy to Terms, which are still adjacent, so only its count changes. Closes vycdev#143
1f88aba to
4f3cd17
Compare
|
The e2e jobs here failed in the "Install Playwright system dependencies" step, before any test ran: the runner couldn't resolve |
The Awards link from #126 added an eighth link to the landing footer. The narrow-screen footer tests in
privacy.spec.tsandterms.spec.tsstill expected seven, sonpm run test:e2e:privacyandnpm run test:e2e:termsfail on all four width/theme cases ondevelop. Their CI jobs,E2E (test:e2e:privacy)andE2E (test:e2e:terms), therefore fail on every pull request and on pushes todevelop. These suites have their own configs, so #137 didn't cover them.As #143 asks, I also checked the other footer assertions against the new link:
Test-only change, so no changelog entry, the same as #137.
Closes #143
Tests
npm run test:e2e:privacy: 13 passed.npm run test:e2e:terms: 10 passed.