Repository navigation
Count the Awards link in the privacy and terms footer tests - #150
Open
officialasishkumar wants to merge 1 commit into
Open
officialasishkumar wants to merge 1 commit into
officialasishkumar wants to merge 1 commit into
Conversation
The Awards link added in vycdev#126 is the eighth link in the landing footer navigation, so the narrow-screen footer tests in the privacy and terms suites failed on `toHaveCount(7)` at 320px and 390px in both themes. vycdev#137 fixed the same cause in the i18n suite, but these suites run under their own Playwright configs and were missed. Both tests now expect eight links, so their per-link checks (fully in view, 44px tall, above the sticky call to action, not covered) run for the Awards link too. In the privacy test, Awards now sits between Support and Privacy in the tab order: the test checks its name and href and tabs through it before reaching Privacy. The terms test tabs from Privacy to Terms, which the new link does not affect. Fixes vycdev#143
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run test:e2e:privacyandnpm run test:e2e:termsfail ondevelop: the narrow-screen footer test in each suite expects 7 footer links, but the Awards link from #126 made it 8. #137 fixed the same cause in the i18n suite; these two suites run under their own configs, so they were missed. This is what keeps the privacy and terms CI jobs red.As #143 asks, the other footer assertions were checked against the new link too:
/awardshref, then tabs on to Privacy.Fixes #143
Validation (Chromium from the official Playwright 1.60 Docker image):
playwright.privacy.config.tsfails the 4 footer tests withExpected: 7, Received: 8, matching the issue.npx playwright test --config playwright.privacy.config.tspasses all 13 tests andnpx playwright test --config playwright.terms.config.tspasses all 10.npx eslint tests --max-warnings=0: passed.