Repository navigation
Update VP9 EncodedVideoChunk data and type definitions #967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Djuffin
wants to merge
1
commit into
w3c:main
Choose a base branch
from
Djuffin:vp9
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,7 +37,7 @@ | |
| <pre class='biblio'> | ||
| { | ||
| "VP9": { | ||
| "href": "https://storage.googleapis.com/downloads.webmproject.org/docs/vp9/vp9-bitstream-specification-v0.6-20160331-draft.pdf", | ||
| "href": "https://storage.googleapis.com/downloads.webmproject.org/docs/vp9/vp9-bitstream-specification-v0.7-20170222-draft.pdf", | ||
| "title": "VP9 Bitstream & Decoding Process Specification", | ||
| "publisher": "The WebM Project" | ||
| }, | ||
|
|
@@ -59,7 +59,14 @@ | |
| ================================================ | ||
|
|
||
| {{EncodedVideoChunk}} {{EncodedVideoChunk/[[internal data]]}} is expected to be | ||
| a frame as described in Section 6 of [[VP9]]. | ||
| a single frame as described in Section 6 of [[VP9]], or a superframe as | ||
| described in Annex B of [[VP9]]. | ||
|
|
||
| Each {{EncodedVideoChunk}} is expected to contain exactly one shown frame (a | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "exactly one shown frame" -- are multiple spatial layers meant to be covered, which would have multiple show frames (sl0, sl1, sl2) in one chunk/superframe? |
||
| frame where `show_frame` is `1` or `show_existing_frame` is `1`, as defined in | ||
| Section 7.2 of [[VP9]]). Unshown frames (such as alternate reference frames, | ||
| where both `show_frame` and `show_existing_frame` are `0`) are expected to be | ||
| bundled together with a shown frame into a superframe. | ||
|
|
||
| VideoDecoderConfig description {#videodecoderconfig-description} | ||
| ================================================================ | ||
|
|
@@ -70,9 +77,9 @@ | |
| ================================================ | ||
|
|
||
| If an {{EncodedVideoChunk}}'s {{EncodedVideoChunk/[[type]]}} is | ||
| {{EncodedVideoChunkType/key}}, then the {{EncodedVideoChunk}} is expected to | ||
| contain a frame with a `frame_type` of `KEY_FRAME` as defined in Section | ||
| 7.2 of [[VP9]]. | ||
| {{EncodedVideoChunkType/key}}, then the first frame in the | ||
| {{EncodedVideoChunk}} is expected to have `show_existing_frame` equal to `0` and | ||
| `frame_type` equal to `KEY_FRAME`, as defined in Section 7.2 of [[VP9]]. | ||
|
|
||
| VideoEncoderEncodeOptions extensions {#videoencoderencodeoptions-extensions} | ||
| ============================================================== | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd test if this works in Safari. I suspect it is expecting super-frames since we have to repack for VideoToolbox.
Chromium and Firefox probably accept both though. If we change this we should add a vp9 specific wpt to exercise both of these (if we don't already have one).
@youennf as FYI.