Repository navigation
Conversation
This came up the last time I raised a PR in this repo, and looks like it's still an issue. We discussed approach last time (I think in the office) an there was no conclusion to what should be done: - Either the current thing so the hook fires? (if that is desired) - Don't fire the job on events from forked PRs? - Something else Anyway, no matter what the team decides, having CI fail for a known reason doesnt seem ideal, so hopfully this will just get merged, even if another option from the above list is then chosen.
outdooracorn
added a commit
that referenced
this pull request
Sep 28, 2026
) The CI job that sends a Mattermost message when a PR is (re-)opened, defined in `.github/workflows/mattermost.yml`, fails with `Error: Input required and not supplied: MATTERMOST_WEBHOOK_URL` for PRs from external repositories. Contributors have expressed a desire for CI workflows to not fail for reasons outside of their control ([1] [2]). This would involve either: * Modifying the failing job so that it successfully runs for all PRs targeted at this repo (as done in [1]) * Preventing the job from running for PRs from external repositories (this PR) The later is the safer option and doesn't risk diverting the team's attention away from the focus topic, so I'm inclined to go that route to start with. [1]: #1277 [2]: wmde/wbaas-deploy#2713
Collaborator
Author
|
Replaced by #1281 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up the last time I raised a PR in this repo, and looks like it's still an issue.
We discussed approach last time (I think in the office) an there was no conclusion to what should be done:
Anyway, no matter what the team decides, having CI fail for a known reason doesnt seem ideal, so hopfully this will just get merged, even if another option from the above list is then chosen.