Repository navigation
Standardize application job definitions - #1289
Open
outdooracorn wants to merge 2 commits into
Open
outdooracorn wants to merge 2 commits into
outdooracorn wants to merge 2 commits into
Conversation
Remove the no-longer-used `DispatchesJobs` trait from `QueueSearchIndexBatches`. The `$this->dispatch()` statement that was making use of this trait was removed in 00c5872 as part of the Laravel 10 upgrade. Bug: T440286
* Use `Illuminate\Foundation\Queue\Queueable` in `App\Jobs\Job` so every application job receives the same dispatching, queue interaction, queue configuration, and model serialization behavior from a single source. * Convert relevant Jobs to inherit from this shared base. * Add an architecture test to check that all queueable jobs extend `App\Jobs\Job`. Bug: T440286
outdooracorn
force-pushed
the
ollie-use-job-base-class
branch
from
October 6, 2026 12:01
f67a007 to
025181a
Compare
outdooracorn
added this pull request to stack #1291
October 6, 2026 21:49
Contributor
|
Oh this is marvelous refactoring, thank you Ollie! One thing I'm not sure about is how the Job Classes that now would extend the base Job class behave with regards to how the queue workers are started (60s vs 90s timeout, also not quite sure with the retries): https://github.com/wbstack/api/blob/main/start.sh#L24 |
deer-wmde
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Illuminate\Foundation\Queue\QueueableinApp\Jobs\Jobso every application job receives the same dispatching, queue interaction, queue configuration, and model serialization behavior from a single source.App\Jobs\Job.Having consistent job behaviour will make it easier to reason about the codebase and ensure shared configuration is applied centrally.
Bug: T440286