Repository navigation
Load Modern only when it's the wiki's default skin - #567
Merged
Merged
Conversation
Load Modern only when the wiki default is modern. Keep the skin packaged for those wikis and update both authoritative and generated LocalSettings files. Bug: T418562
dati18
force-pushed
the
feat/deprecate-modern-skin
branch
from
October 12, 2026 15:08
470723a to
8a620b2
Compare
dati18
previously approved these changes
Oct 12, 2026
outdooracorn
changed the title
outdooracorn
previously approved these changes
Oct 13, 2026
outdooracorn
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the skin packaged and loaded for those wikis that have set it as the default.
Update both the authoritative and generated
LocalSettings.phpfiles.This makes the assumption that users have not specifically selected modern as a user preference, and that if they have we don't worry about it (see my comment in the ticket).
If a wiki user has previously selected Modern as their individual preferred skin on a wiki whose default is another skin, MediaWiki falls back to the wiki's configured default when the Modern skin isn't loaded. It does not cause an error or fallback warning. The saved user preference of "modern" isn't cleared, but it won't take effect while Modern is unavailable.
Bug: T418562