Skip to content

fix: require logger before active_record - #8

Merged
prabhjotlalli merged 1 commit into
wealthsimple:masterfrom
prabhjotlalli:require-logger-before-active-record
Oct 22, 2026
Merged

prabhjotlalli merged 1 commit into
wealthsimple:masterfrom
prabhjotlalli:require-logger-before-active-record

Conversation

@prabhjotlalli

Copy link
Copy Markdown
Contributor

concurrent-ruby 1.3.5 no longer requires logger, and ActiveSupport < 7.1 references ::Logger while loading, so require 'active_record' fails with:

NameError: uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger

This broke Test (2.6, 6.1) on #7 (run). require 'logger' was already present but came after active_record; this moves it to the top.

🤖 Generated with Claude Code

@prabhjotlalli
prabhjotlalli merged commit 582baf7 into wealthsimple:master Oct 22, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant