Repository navigation
chore: additional deslag lints - #509
Merged
Merged
Conversation
Onboard .agents/skills/**/*.md to deslag. The skills whose frontmatter says `llm-edit: false` are excluded by path, since their owner does not want automatic prose edits. Fix the lint hits in mx-api-classify-roundtrip-failures. Ban "knob" and "knobs" in the md and cpp lints, and replace the existing uses with the real term (field, parameter) in the gen docs, the gen press engine docstrings, the review instructions and the api doctrine.
webern
marked this pull request as ready for review
November 9, 2026 10:04
Contributor
gen-quality
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends deslag to the agent skills and bans the word "knob".
deslag.tomlnow lints/.agents/skills/**/*.md..claude/skillsis a symlink to the same directory, so only the.agentspath is listed.llm-edit: false(mx-api-doctrine,mx-comments,mx-open-issue,mx-open-pr) are excluded by exact path, since their owner does not want automatic prose edits.mx-commentsandmx-api-doctrinegain the marker in this PR.mx-api-classify-roundtrip-failureswas the only skill with lint hits. They are fixed without changing its meaning: emphasis removed, em dashes and an arrow replaced, and a few negations reworded.mdandcpplints. The existing uses are replaced with the real term (field or parameter) ingen/AGENTS.md,gen/DESIGN.md, thegen/press/engine.pydocstring, a comment ingen/tests/test_press.py, the review instructions under.github/instructions/, and themx-api-doctrineheading.mx-open-issueandmx-open-prskills andapi-headers.instructions.mdare also rewrapped to 100 columns.No code behavior changes: the Python edits are in docstrings and comments.
Testing
make fmt-checkpasses (clang-format anddeslag check)deslag explainshows the fourllm-edit: falseskills excluded, including through the.claude/skillssymlinkgen/press/engine.pyandgen/tests/test_press.pybyte-compileReferences
fmt-check