Remove origin-keyed agent cluster requirement - #330
Merged
Merged
Conversation
domfarolino
approved these changes
Sep 30, 2026
github-actions Bot
added a commit
that referenced
this pull request
Sep 30, 2026
SHA: d61d0e6 Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
brave-builds
pushed a commit
to brave/chromium
that referenced
this pull request
Sep 30, 2026
Previously, document.modelContext's registerTool(), getTools() and executeTool() rejected with a SecurityError, and declarative tools were silently not registered, when the document was not in an origin-keyed agent cluster (i.e. when document.domain could be used). The spec no longer has this requirement, so remove the check. This also removes the tests that asserted the old behavior, including the --disable-web-security exception test, which is now moot. Spec PR: webmachinelearning/webmcp#330 Bug: 489045948 Change-Id: I8ab7fcacd73f879e9bdb73f9eaf3ea9a21cada75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8479638 Reviewed-by: Dominic Farolino <dom@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#1708220}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 30, 2026
Previously, document.modelContext's registerTool(), getTools() and executeTool() rejected with a SecurityError, and declarative tools were silently not registered, when the document was not in an origin-keyed agent cluster (i.e. when document.domain could be used). The spec no longer has this requirement, so remove the check. This also removes the tests that asserted the old behavior, including the --disable-web-security exception test, which is now moot. Spec PR: webmachinelearning/webmcp#330 Bug: 489045948 Change-Id: I8ab7fcacd73f879e9bdb73f9eaf3ea9a21cada75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8479638 Reviewed-by: Dominic Farolino <dom@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#1708220}
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this pull request
Oct 1, 2026
This check is not a requirement anymore, so the plaster and customisation can be deleted. Chromium changes: https://chromium.googlesource.com/chromium/src/+/76779c44a13be0ddd48a9ea356609c4a28d713e6 commit 76779c44a13be0ddd48a9ea356609c4a28d713e6 Author: Fran莽ois Beaufort <beaufort.francois@gmail.com> Date: Wed Sep 30 09:54:24 2026 -0700 [WebMCP] Remove origin-keyed agent cluster requirement Previously, document.modelContext's registerTool(), getTools() and executeTool() rejected with a SecurityError, and declarative tools were silently not registered, when the document was not in an origin-keyed agent cluster (i.e. when document.domain could be used). The spec no longer has this requirement, so remove the check. This also removes the tests that asserted the old behavior, including the --disable-web-security exception test, which is now moot. Spec PR: webmachinelearning/webmcp#330 Bug: 489045948 Change-Id: I8ab7fcacd73f879e9bdb73f9eaf3ea9a21cada75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8479638 Reviewed-by: Dominic Farolino <dom@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#1708220}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX #318
Preview | Diff