Repository navigation
fix: keep first parameter after ( in normalizeSignature - #516
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
Merged
This was referenced Oct 20, 2026
Merged
jxom
added a commit
that referenced
this pull request
Oct 25, 2026
…`, `Hex`, and `RpcTransport` (#527) * fix: keep empty `version` in `TypedData.extractEip712DomainTypes` Ports wevm/viem#5240. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0133zgX2g8oLCoH4KuY8tM9b * feat: add `even` option to `Hex.assert` and `Hex.validate` Ports wevm/viem#5283. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0133zgX2g8oLCoH4KuY8tM9b * fix: array overload resolution in `AbiItem.fromAbi` Ports wevm/viem#5281. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0133zgX2g8oLCoH4KuY8tM9b * fix: `AbiEvent.assertArgs` `string` and `bytes` matching Ports wevm/viem#5238 and wevm/viem#5280. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0133zgX2g8oLCoH4KuY8tM9b * fix: apply `RpcTransport.fromHttp` timeout to the response body and with a caller signal Ports wevm/viem#5200. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0133zgX2g8oLCoH4KuY8tM9b * fix: keep first parameter after `( ` in normalizeSignature (#516) (cherry picked from commit 36dce4a) * test: format `Hex` and `RpcTransport` tests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0133zgX2g8oLCoH4KuY8tM9b * fix: read tuple object args by name and match empty arrays in `AbiItem.fromAbi` overloads Syncs with the merged wevm/viem#5281: tuple object args are read by component name, and an empty array is ambiguous for `address[]` vs `string[]`/`bytes[]`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0133zgX2g8oLCoH4KuY8tM9b * fix: use a line comment for `getComponentValue` to satisfy `check:tsdoc` Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0133zgX2g8oLCoH4KuY8tM9b * fix(docgen): link to variables in API docs Ports the `Variable` case of `getLinkForApiItem` from `main` (#414). Without it, the `{@link ox#AccountConfig.maxSignatures}` reference added in #509 fails `docs:gen` and every `0.x` docs deployment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0133zgX2g8oLCoH4KuY8tM9b * fix: keep the caller signal when `AbortSignal.any` is missing in `RpcTransport.fromHttp` `AbortSignal.any` is missing on Node < 18.17 and older browsers, which the 0.x line supports. There, the transport now uses the caller signal alone, as it did before, instead of throwing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0133zgX2g8oLCoH4KuY8tM9b * test: restore `AbortSignal.any` by property descriptor Matches the main-branch test in #526. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0133zgX2g8oLCoH4KuY8tM9b --------- Co-authored-by: Claude <noreply@anthropic.com>
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
normalizeSignaturedropping the first parameter when a space directly follows((e.g.function ownerOf( uint256 tokenId )), which produced wrong selectors and signatures.Mirrors wevm/viem#5201.