🔧 update: make sqlite runtime loading safe for node-targeted bundles - #2
Merged
Merged
Conversation
Co-authored-by: warengonzaga <15052701+warengonzaga@users.noreply.github.com>
Co-authored-by: warengonzaga <15052701+warengonzaga@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Node-targeted npm CLIs failing due to bun:sqlite import
Make SQLite runtime loading safe for Node-targeted bundles
Mar 17, 2026
warengonzaga
marked this pull request as ready for review
July 4, 2026 12:01
There was a problem hiding this comment.
Pull request overview
This PR makes the SQLite backend selection safe for Node-targeted bundled artifacts by ensuring the Bun SQLite driver is only resolved at runtime, preventing bun:* imports from leaking into Node bundles.
Changes:
- Switch Bun SQLite loading to runtime-only resolution (avoid static
bun:sqliteimports). - Add a bundling-focused runtime test to validate Node-targeted output can be loaded and doesn’t include a static
bun:sqliteimport. - Document that the Bun SQLite backend is loaded only at runtime, improving guidance for Node consumers.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/runtime.ts |
Uses runtime resolution to avoid static bun:sqlite imports in Node-targeted bundles while preserving Bun-first behavior. |
tests/runtime.test.ts |
Adds a bundling regression test for Node-targeted output safety. |
README.md |
Documents runtime-only Bun SQLite loading for Node-targeted bundle compatibility. |
… test - Import openDatabase alongside isBun so the bundler cannot eliminate the SQLite adapter code, ensuring bun:sqlite guard is actually tested - Switch to file:// URL for runtime path for cross-platform portability Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node-targeted CLIs consuming
@wgtechlabs/config-enginecould still fail at runtime because bundled output retained abun:sqliteimport. This change keeps Bun as the primary runtime while making the package safe to load from Node-targeted artifacts.Runtime adapter loading
better-sqlite3via the existing adapter path.bun:*imports into Node bundles.Bundling regression coverage
target: "node".bun:sqliteimport and can be loaded by Node.Documentation
Original prompt
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.