Skip to content

Restore upstream's Muse usage test and drop the dead usage snapshot reconcile #116

Open

Description

@wianvdm

Parent: #30. Found by the v0.1.9 sync council (PR #111). Related: #104.

  • Lost upstream test. The fork deletes upstream's packages/provider-muse/src/server/usageLimits.test.ts. v0.1.9 added a museUsageToLimits test there; git matched it by rename to packages/plusplus/src/museUsageLimits.test.ts, where the sync dropped it because the function is upstream-only. Upstream's museUsageToLimits now has no test in the fork.
  • Dead export. The sync split the fork's usage-account retention out as retainPublishedUsageAccounts; reconcileProviderUsageSnapshot in packages/plusplus/src/usageLimits.ts (~line 145) now has no production caller.

Acceptance criteria

  • Upstream's usageLimits.test.ts is restored at upstreamRef with ++ cases kept in ++-owned tests (per Move ++ tests out of upstream test files #91), and its registry entry is removed or shrunk.
  • reconcileProviderUsageSnapshot and its tests are deleted, or a production caller is named.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    acceptedMaintainer/triage-approved workplusplus++ fork work

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions