Skip to content

fix: accept call on lockscreen when app is locked [WPB-25850] - #5311

Merged
saleniuk merged 3 commits into
developfrom
fix/accept-call-on-lockscreen-with-applock
Sep 25, 2026
Merged

saleniuk merged 3 commits into
developfrom
fix/accept-call-on-lockscreen-with-applock

Conversation

@saleniuk

@saleniuk saleniuk commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-25850


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

On Android (Google Pixel, latest OS), incoming calls cannot be accepted on lock screen when app is locked and uses biometrics.

Causes (Optional)

Biometrics cannot be used when the device is locked.

Solutions

Exclude incoming call screen and its actions from being under the app-lock, so allow users to accept the call while app is locked - it doesn't require unlocking the app and opening AppLockActivity anymore thus the biometrics are never used when device is locked. At the same time change to allow only incoming call screen to be shown when device is locked, so other screens, like for instance ongoing call after accepting, are available only after unlocking the device and app if app-lock is enabled - this is unified with iOS. These changes mean that now app-lock needs to be checked on ongoing call screen (OngoingCallActivity) in a single place rather than for multiple actions on incoming call screen, so it simplifies the logic a bit. For biometrics dialog, wait until the lifecycle is resumed to show the biometric prompt, otherwise it silently fails to show it and never retries leaving user with empty screen. Additionally, call activities are being open in a new task so AppLockActivity can be triggered twice for call and regular task, so now it checks and closes itself when it notices that the app has just been unlocked.

Testing

How to Test

Use a device with biometrics, open Wire app, enable app-lock, close the app, turn off the screen, receive incoming call and try to accept it.

Attachments (Optional)

Without biometrics:

Screen.Recording.2026-09-21.at.18.29.21.mov

With biometrics:

PXL_20260921_160701081.TS.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Test Results

  347 files  ±0    347 suites  ±0   1m 50s ⏱️ -1s
2 839 tests +5  2 839 ✅ +5  0 💤 ±0  0 ❌ ±0 
2 845 runs  +5  2 845 ✅ +5  0 💤 ±0  0 ❌ ±0 

Results for commit 911b743. ± Comparison against base commit 049fd33.

This pull request removes 7 and adds 12 tests. Note that renamed tests count towards both.
com.wire.android.ui.authentication.login.sso.LoginSSOViewModelTest ‑ given automated nomad login, when establishSSOSession is called twice, then nomad url is consumed once()
com.wire.android.ui.calling.incoming.IncomingCallViewModelTest ‑ given app Locked, when the user decline the call, then do not reject the call until is unlocked()
com.wire.android.ui.calling.incoming.IncomingCallViewModelTest ‑ given app Locked, when the user decline the call, then do not reject the call()
com.wire.android.ui.calling.incoming.IncomingCallViewModelTest ‑ given app locked, when user tries to accept an incoming call, then do not accept the call until is unlocked()
com.wire.android.ui.calling.incoming.IncomingCallViewModelTest ‑ given app locked, when user tries to accept an incoming call, then do not accept the call()
com.wire.android.ui.calling.incoming.IncomingCallViewModelTest ‑ given app locked, when user tries to accept an second incoming call, then do not accept the call until is unlocked()
com.wire.android.ui.newauthentication.login.NewLoginViewModelTest ‑ given automated nomad login, when handling SSO result twice, then nomad url is consumed once()
com.wire.android.search.apps.SearchAppsViewModelTest ‑ given app refresh fails, when loading Apps, then cached Apps are still emitted()
com.wire.android.ui.authentication.login.SavedStateLoginSavedInputStoreTest ‑ givenPendingSso_whenStoreIsRecreated_thenIdentityBackendAndRouteArePreserved()
com.wire.android.ui.authentication.login.sso.LoginSSOViewModelExtensionTest ‑ code SSO supplies IdP only when capability is enabled()
com.wire.android.ui.authentication.login.sso.LoginSSOViewModelExtensionTest ‑ different backend context cannot complete login()
com.wire.android.ui.authentication.login.sso.LoginSSOViewModelExtensionTest ‑ email SSO bypasses capability and preserves its existing IdP()
com.wire.android.ui.authentication.login.sso.LoginSSOViewModelExtensionTest ‑ settings failure stops before storing or opening a session()
com.wire.android.ui.authentication.login.sso.LoginSSOViewModelTest ‑ given automated nomad login, when establishSSOSession is called twice, then second callback is rejected()
com.wire.android.ui.authentication.login.sso.LoginSSOViewModelTest ‑ given missing pending SSO context, when callback succeeds, then reject it before establishing session()
com.wire.android.ui.newauthentication.login.NewLoginViewModelTest ‑ SSO initiation retains backend identity and route across view model recreation()
com.wire.android.ui.newauthentication.login.NewLoginViewModelTest ‑ failed new SSO attempt discards previous identity and route()
…

♻️ This comment has been updated with latest results.

@codecov

codecov Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 54.31%. Comparing base (a745a61) to head (911b743).
⚠️ Report is 16 commits behind head on develop.

Files with missing lines Patch % Lines
...droid/ui/calling/incoming/IncomingCallViewModel.kt 94.73% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5311      +/-   ##
===========================================
+ Coverage    53.83%   54.31%   +0.48%     
===========================================
  Files          755      757       +2     
  Lines        26303    26459     +156     
  Branches      4348     4377      +29     
===========================================
+ Hits         14161    14372     +211     
+ Misses       10765    10691      -74     
- Partials      1377     1396      +19     
Files with missing lines Coverage Δ
...e/android/ui/calling/incoming/IncomingCallState.kt 100.00% <ø> (ø)
.../android/ui/calling/ongoing/OngoingCallActivity.kt 83.33% <ø> (ø)
...droid/ui/calling/incoming/IncomingCallViewModel.kt 91.07% <94.73%> (+8.35%) ⬆️

... and 28 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a745a61...911b743. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Comment thread app/src/main/kotlin/com/wire/android/ui/AppLockActivity.kt Outdated
@github-actions

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@saleniuk
saleniuk added this pull request to the merge queue Sep 25, 2026
Merged via the queue into develop with commit a29806a Sep 25, 2026
22 checks passed
@saleniuk
saleniuk deleted the fix/accept-call-on-lockscreen-with-applock branch September 25, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants