fix: guest mode for new channel (WPB-28029) - #5318
Open
sbakhtiarov wants to merge 2 commits into
Open
sbakhtiarov wants to merge 2 commits into
sbakhtiarov wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5318 +/- ##
===========================================
+ Coverage 54.33% 54.36% +0.03%
===========================================
Files 757 757
Lines 26489 26490 +1
Branches 4384 4389 +5
===========================================
+ Hits 14392 14402 +10
+ Misses 10696 10688 -8
+ Partials 1401 1400 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
saleniuk
approved these changes
Sep 24, 2026
Contributor
|
APKs built during tests are available here. Scroll down to Artifacts! |
ohassine
approved these changes
Sep 25, 2026
Comment on lines
230
to
235
| fun onRequestGuestRoomLink() { | ||
| if (shouldDisableGenerateGuestLinkButton()) return | ||
| viewModelScope.launch { | ||
| if (shouldDisableGenerateGuestLinkButton()) return@launch | ||
| safeCreateGuestLink(null) | ||
| } |
Member
There was a problem hiding this comment.
is there a reason to duplicate shouldDisableGenerateGuestLinkButton() check ?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-28029
https://wearezeta.atlassian.net/browse/WPB-28029
What's new in this PR?
Issues
Backend-created channels could incorrectly show Guest Access as ON and allow link creation that the backend rejects.
Solutions
Use Kalium’s combined Guest Access check, block link creation while access is disabled or updating, and preserve existing guest permissions when changing Apps Access.