Skip to content

Add override for DEFAULT_MAX_PACKET_SZ in stm32h563 port - #165

Closed
etrian-dev wants to merge 1 commit into
wolfSSL:masterfrom
etrian-dev:default_packet_sz
Closed

Add override for DEFAULT_MAX_PACKET_SZ in stm32h563 port#165
etrian-dev wants to merge 1 commit into
wolfSSL:masterfrom
etrian-dev:default_packet_sz

Conversation

@etrian-dev

@etrian-dev etrian-dev commented Aug 28, 2026

Copy link
Copy Markdown

Commit wolfSSL/wolfssh@050dee0 added tighter checks on packet size, making compilation of the port fail with:

arm-none-eabi-gcc -mcpu=cortex-m33 -mthumb -Os -ffreestanding -fdata-sections -ffunction-sections -g -ggdb -Wall -Wextra -I. -I../../.. -I../../../src -I../../../src/port -I../../../src/port/stm32 -DSTM32H5 -Wno-unused-variable -Wno-unused-function -DENABLE_SSH -DWOLFSSL_USER_SETTINGS -DWOLFSSH_USER_SETTINGS -I../../../../wolfssh -I../../../../wolfssl -c ../../../../wolfssh/src/log.c -o ../../../../wolfssh/src/log.o
In file included from ssh_server.c:26:
../../../../wolfssh/wolfssh/internal.h:764:6: error: #error "DEFAULT_MAX_PACKET_SZ too large to frame inside MAX_PACKET_SZ"
  764 |     #error "DEFAULT_MAX_PACKET_SZ too large to frame inside MAX_PACKET_SZ"
      |      ^~~~~

Compile-tested against the default configuration for the port

…INDOW_SZ.

Fixes a build error due to tighter checks introduced in wolfSSH in
commit 050dee0fbff3 ("Bound channel maxPacketSz below the wire limit")

Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
@etrian-dev
etrian-dev marked this pull request as ready for review August 29, 2026 10:18
@dgarske

dgarske commented Aug 31, 2026

Copy link
Copy Markdown
Member

Hi @etrian-dev, thank you for your contribution! Can you tell us more about your project and if you plan to submit any additional PR's? Since this is a small change we might treat as bug report and fix ourselves. See https://github.com/wolfSSL/wolfssh/blob/master/CONTRIBUTING.md for details.
Thanks, David Garske, wolfSSL

@etrian-dev

Copy link
Copy Markdown
Author

Hi @etrian-dev, thank you for your contribution! Can you tell us more about your project and if you plan to submit any additional PR's? Since this is a small change we might treat as bug report and fix ourselves. See https://github.com/wolfSSL/wolfssh/blob/master/CONTRIBUTING.md for details. Thanks, David Garske, wolfSSL

Hi @dgarske,I will do that; I may submit additional PRs if I notice some other build failures (I reported a transient one a couple of months ago). I double checked with my employer and it's ok for them.
Thanks,
Nicola

@anhu

anhu commented Sep 1, 2026

Copy link
Copy Markdown
Member

Off-line, @etrian-dev and I have agreed that this should be treated as a bug report.
@danielinux , I'm assigning this to you to handle.

@anhu anhu assigned danielinux and unassigned danielinux and wolfSSL-Bot Sep 1, 2026
@nvetrini

nvetrini commented Sep 3, 2026

Copy link
Copy Markdown

Seems like a384fee fixed this. Thus, the PR can be closed

@etrian-dev etrian-dev closed this Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants