Skip to content

test(android): pin Robolectric tests to SDK 35 in robolectric.properties #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcalhoun merged 3 commits into from
Sep 24, 2026
Merged

test(android): pin Robolectric tests to SDK 35 in robolectric.properties #727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7959605
test(android): pin the Robolectric SDK once in robolectric.properties
dcalhoun Sep 24, 2026
3d0ce91
test(android): run Robolectric tests against SDK 35
dcalhoun Sep 24, 2026
d9e9454
docs(android): correct where Robolectric's default SDK comes from
dcalhoun Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions android/Gutenberg/src/test/java/org/wordpress/gutenberg/GutenbergViewTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import org.robolectric.RobolectricTestRunner
import org.robolectric.RuntimeEnvironment
import org.robolectric.Shadows.shadowOf
import org.robolectric.shadows.ShadowDialog
import org.robolectric.annotation.Config
import org.junit.Assert.assertEquals
import org.junit.Assert.assertFalse
import org.junit.Assert.assertTrue
Expand All @@ -31,7 +30,6 @@ import org.wordpress.gutenberg.model.EditorConfiguration
import org.wordpress.gutenberg.model.EditorDependencies

@RunWith(RobolectricTestRunner::class)
@Config(sdk = [28])
class GutenbergViewTest {
@Mock
private lateinit var mockWebView: WebView
Expand Down
2 changes: 1 addition & 1 deletion android/Gutenberg/src/test/java/org/wordpress/gutenberg/GutenbergViewUploadServerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import org.wordpress.gutenberg.model.EditorConfiguration
import org.wordpress.gutenberg.model.EditorDependencies

@RunWith(RobolectricTestRunner::class)
@Config(sdk = [28], manifest = Config.NONE)
@Config(manifest = Config.NONE)
class GutenbergViewUploadServerTest {

private val testScope = TestScope()
Expand Down
2 changes: 0 additions & 2 deletions android/Gutenberg/src/test/java/org/wordpress/gutenberg/inserter/SvgIconCacheTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,12 @@ import org.junit.Assert.assertTrue
import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.RobolectricTestRunner
import org.robolectric.annotation.Config

/**
* Robolectric is required because [parseSvgColor] delegates to [Color.parseColor]
* for named colours and the resulting ARGB ints are produced via [Color.argb].
*/
@RunWith(RobolectricTestRunner::class)
@Config(sdk = [28])
class SvgIconCacheTest {

// -- parseSvgColor ----------------------------------------------------
Expand Down
2 changes: 0 additions & 2 deletions android/Gutenberg/src/test/java/org/wordpress/gutenberg/views/EditorErrorViewTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,9 @@ import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.RobolectricTestRunner
import org.robolectric.RuntimeEnvironment
import org.robolectric.annotation.Config
import org.wordpress.gutenberg.R

@RunWith(RobolectricTestRunner::class)
@Config(sdk = [28])
class EditorErrorViewTest {

@Test
Expand Down
2 changes: 2 additions & 0 deletions android/Gutenberg/src/test/resources/robolectric.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Robolectric otherwise defaults to the manifest's targetSdk, which requires a newer JVM than CI runs.
sdk=35
Loading