Skip to content

Add test for language core update respecting --quiet - #195

Draft
swissspidy wants to merge 1 commit into
mainfrom
claude/charming-tesla-ckc7ks
Draft

swissspidy wants to merge 1 commit into
mainfrom
claude/charming-tesla-ckc7ks

Conversation

@swissspidy

Copy link
Copy Markdown
Member

Adds a Behat scenario to check the behavior reported in #194, where wp --quiet language core update was said to still print Updating '…' translation for WordPress ….

The scenario:

  1. Installs WordPress 6.5 with the de_DE_formal and ja language packs.
  2. Switches core to 6.6 so both packs report update: available.
  3. Runs wp --quiet language core update and asserts that STDOUT and STDERR are both empty.
  4. Lists the languages again and asserts both now report update: none, so the updates really were applied.

The scenario passes locally (run against SQLite), meaning the issue does not reproduce on current main with WP-CLI 3.x: the message is emitted via WP_CLI::log(), which --quiet already discards. No code change is included, only the test.

One code path where these lines do get through --quiet is an alias group (wp @all --quiet …), because WP-CLI intentionally strips quiet from the per-site subprocesses and only hides the @alias headers. That is not covered here.

Related: #194


Generated by Claude Code

See #194.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UWTd5qTjoQCiifsdFD3jyV
@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added automated-pr command:language-core-update Related to 'language core update' command scope:testing Related to testing labels Nov 16, 2026
@codecov

codecov Bot commented Nov 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-pr command:language-core-update Related to 'language core update' command scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants