Repository navigation
Add test for language core update respecting --quiet - #195
Draft
swissspidy wants to merge 1 commit into
Draft
swissspidy wants to merge 1 commit into
swissspidy wants to merge 1 commit into
Conversation
See #194. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UWTd5qTjoQCiifsdFD3jyV
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Behat scenario to check the behavior reported in #194, where
wp --quiet language core updatewas said to still printUpdating '…' translation for WordPress ….The scenario:
de_DE_formalandjalanguage packs.update: available.wp --quiet language core updateand asserts that STDOUT and STDERR are both empty.update: none, so the updates really were applied.The scenario passes locally (run against SQLite), meaning the issue does not reproduce on current
mainwith WP-CLI 3.x: the message is emitted viaWP_CLI::log(), which--quietalready discards. No code change is included, only the test.One code path where these lines do get through
--quietis an alias group (wp @all --quiet …), because WP-CLI intentionally stripsquietfrom the per-site subprocesses and only hides the@aliasheaders. That is not covered here.Related: #194
Generated by Claude Code