Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #250 +/- ##
==========================================
+ Coverage 70.53% 72.26% +1.73%
==========================================
Files 61 61
Lines 8566 8517 -49
Branches 952 963 +11
==========================================
+ Hits 6042 6155 +113
+ Misses 2524 2362 -162 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rpreen
force-pushed
the
exception_handling
branch
3 times, most recently
from
November 1, 2026 18:09
c3e1c6b to
965540b
Compare
| xcsf->status = code; | ||
| va_list args; | ||
| va_start(args, fmt); | ||
| vsnprintf(xcsf->err_msg, sizeof(xcsf->err_msg), fmt, args); |
rpreen
force-pushed
the
exception_handling
branch
3 times, most recently
from
November 1, 2026 21:42
cfc1d5a to
72e913a
Compare
rpreen
force-pushed
the
exception_handling
branch
from
November 1, 2026 23:31
72e913a to
f24bff1
Compare
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




WIP: resolves #200
The idea is to replace all current C error handling calls to
exit()with a call toxcsf_set_error()which sets an errorstatus(int) and aerr_msg(char[256]) in theXCSFdata structure. The errors should then be allowed to bubble up to eithermain.cwhich can callexit()orpybind_wrapper.cppwhich can throw an exception that is then used by the Python interpreter.Unfortunately this will touch a lot of files.