Repository navigation
feat: make translation cache column opt-in and more compact - #17
Open
YvetteNikolov wants to merge 2 commits into
Open
YvetteNikolov wants to merge 2 commits into
YvetteNikolov wants to merge 2 commits into
Conversation
The column added a wide column to every public post type list screen. The uncached and incomplete request counters only fed this column, so they go with it instead of writing post meta on every visitor request.
YvetteNikolov
requested review from
ShunLuk,
SimonvanWijhe,
dtakken,
ictbeheer,
mvdhoek1,
richardkorthuis and
rivanuff
and
a balanced review from Copilot
and removed request for
a team
November 10, 2026 15:25
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the Translation cache column removal.
No open issues 🎉
What changed in this PR
Removes the Translation cache column from WordPress post lists to reduce clutter, while preserving the cache metabox, translation caching, and rate limiting.
Changes:
- Removes the column provider, styles, compiled assets, and webpack entry.
- Removes request counters used only by the column, eliminating their post-meta writes.
- Updates tests and documentation to reflect the removal; existing counter metadata is left untouched.
| File | Description |
|---|---|
webpack.config.js |
Removes the admin-column build entry. |
tests/Unit/TranslationServiceTest.php |
Removes counter assertions while retaining cache checks. |
tests/Unit/TranslationRepositoryTest.php |
Removes counter tests and retains cache-deletion coverage. |
tests/Unit/RestAPIControllerTest.php |
Removes the incomplete-request counter test. |
tests/Unit/AdminColumnsServiceProviderTest.php |
Deletes column-rendering tests. |
src/Traits/CachePostTypesTrait.php |
Removes a comment referencing the deleted provider. |
src/Services/TranslationService.php |
Removes request-counter calls and delegation. |
src/Repositories/TranslationRepository.php |
Removes column data queries and counter management. |
src/Providers/AdminColumnsServiceProvider.php |
Deletes column registration, rendering, and stylesheet loading. |
src/Controllers/RestAPIController.php |
Stops recording incomplete-request counts. |
src/Bootstrap.php |
Removes the column provider registration and import. |
readme.txt |
Removes column and badge documentation. |
README.md |
Removes column and badge documentation. |
dist/admin-columns.js |
Removes the generated column JavaScript artifact. |
dist/admin-columns.css |
Removes compiled column styles. |
dist/admin-columns.asset.php |
Removes generated column asset metadata. |
assets/css/admin-columns.css |
Deletes column badge source styles. |
Review effort: Balanced
Restores the column and its counters, but only registers it when enabled on the settings page. Shortens the label to "Cache" and narrows the column to 6%.
YvetteNikolov
changed the title
mvdhoek1
approved these changes
Nov 12, 2026
| } | ||
|
|
||
| /** | ||
| * @since 2.3.0 |
Contributor
There was a problem hiding this comment.
@since 2.3.0 -> @since NEXT, als iemand anders nu die versie uitbrengt klopt het niet meer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The translation cache column made already crowded list screens wider. Now:
Before (column takes an equal share, 619px at 1600px viewport)
After (6%, 160px)
Tests:
pestpasses (20 tests). Checked locally: column is gone by default and comes back compact once enabled.🤖 Generated with Claude Code