Skip to content

Fix Bilibili cover HTTPS and referrer handling - #15

Merged
yichen11818 merged 1 commit into
mainfrom
codex/fix-bilibili-covers
Oct 21, 2026
Merged

yichen11818 merged 1 commit into
mainfrom
codex/fix-bilibili-covers

Conversation

@yichen11818

@yichen11818 yichen11818 commented Oct 21, 2026 •

Copy link
Copy Markdown
Owner

Bilibili can return HTTP cover URLs, and its image CDN rejects requests with an external Referer. Normalize old search/favorite CDN URLs to HTTPS at display time and explicitly set no-referrer on cover images across search, queue, favorites, history, player and lyrics. Render the lyrics backdrop as a decorative image so it uses the same request policy.

Validation:

  • Frontend typecheck, 9 tests, production and demo builds passed locally. All PR checks and Docker builds passed on GitHub.
  • Called the actual backend.main.bilibili_search_videos implementation with a music query, then passed three returned artwork URLs through the actual TypeScript artworkUrl helper. All three image requests returned 200/image/jpeg without a Referer, and all three returned 403 with an external Referer.
  • Separately verified a real HTTP cover URL returned by the video metadata API remains available over HTTPS.
  • The existing document-wide no-referrer policy is retained. These checks confirm a CDN failure condition and URL compatibility; they do not prove that the reporter's deployed browser sent a Referer.

@yichen11818
yichen11818 merged commit e0668f3 into main Oct 21, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant