Skip to content

Switch to infection/infection - #351

Merged
vjik merged 2 commits into
masterfrom
switch2infection
Nov 1, 2026
Merged

vjik merged 2 commits into
masterfrom
switch2infection

Conversation

@vjik

@vjik vjik commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

Summary by Sourcery

Switch mutation testing from the Roave plugin to the standard Infection package.

Enhancements:

  • Replace the Roave Infection static-analysis plugin with the standard Infection package for mutation testing.

CI:

  • Update the mutation-testing workflow to use the Infection workflow and ignore mutants with no mutation score impact.

Documentation:

  • Update mutation-testing documentation to reference the standard Infection command.

Chores:

  • Update development dependencies and local mutation-testing commands for the Infection package.

@sourcery-ai

sourcery-ai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR migrates mutation testing from Roave’s static-analysis plugin to the standard Infection package, updating development dependencies, local commands, documentation, and the reusable CI workflow while preserving existing execution options and dashboard integration.

File-Level Changes

Change Details Files
Replace the Roave Infection plugin with the standard Infection package across dependencies and developer commands.
  • Add Infection with compatible version constraints and remove the Roave plugin.
  • Update the Makefile mutation target to invoke the Infection binary with equivalent options.
  • Update contributor documentation to use the standard Infection command.
composer.json
Makefile
docs/internals.md
Migrate CI mutation testing to the standard Infection workflow and configure mutation-score handling.
  • Switch the reusable workflow from the Roave-specific workflow to the Infection workflow.
  • Pass the option to ignore mutation-score indicators that have no mutations.
  • Retain the Ubuntu/PHP matrix and Stryker Dashboard secret configuration.
.github/workflows/mutation.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@codecov

codecov Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.15%. Comparing base (e3c4c92) to head (329bb3c).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #351   +/-   ##
=========================================
  Coverage     95.15%   95.15%           
  Complexity      395      395           
=========================================
  Files            59       59           
  Lines          1031     1031           
=========================================
  Hits            981      981           
  Misses           50       50           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vjik
vjik marked this pull request as ready for review November 1, 2026 15:00

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="Makefile" line_range="34" />
<code_context>
 mutation: infection
 infection: ## [infection] Run mutation testing with Infection.
-	$(RUN) ./vendor/bin/roave-infection-static-analysis-plugin --threads=max --ignore-msi-with-no-mutations --only-covered
+	$(RUN) ./vendor/bin/infection --threads=max --ignore-msi-with-no-mutations --only-covered

 psalm: ## Run Psalm static analysis: `make psalm ARGS="--show-info=true"`
</code_context>
<issue_to_address>
**Static checks no longer gate mutants**

When a generated mutant violates a static-analysis check but still runs through the mutation tests, the standard Infection command runs without a static-analysis tool configured, so mutants that violate Psalm checks are no longer rejected during mutation testing and the results lose the previous static-analysis validation.

Configure Infection’s static-analysis integration with the project’s chosen analyzer in `infection.json.dist` or pass the corresponding option in both local and CI commands.

Also at `.github/workflows/mutation.yml:33`, `composer.json:48`.
</issue_to_address>

Sourcery assessment

Approval pending. 1 finding to address first.

Blocking findings: Makefile:34


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Comment thread Makefile
mutation: infection
infection: ## [infection] Run mutation testing with Infection.
$(RUN) ./vendor/bin/roave-infection-static-analysis-plugin --threads=max --ignore-msi-with-no-mutations --only-covered
$(RUN) ./vendor/bin/infection --threads=max --ignore-msi-with-no-mutations --only-covered

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium · Static checks no longer gate mutants

When a generated mutant violates a static-analysis check but still runs through the mutation tests, the standard Infection command runs without a static-analysis tool configured, so mutants that violate Psalm checks are no longer rejected during mutation testing and the results lose the previous static-analysis validation.

Configure Infection’s static-analysis integration with the project’s chosen analyzer in infection.json.dist or pass the corresponding option in both local and CI commands.

Also at .github/workflows/mutation.yml:33, composer.json:48.

Prompt for AI agents
In `Makefile` at line 34:

**Static checks no longer gate mutants**

When a generated mutant violates a static-analysis check but still runs through the mutation tests, the standard Infection command runs without a static-analysis tool configured, so mutants that violate Psalm checks are no longer rejected during mutation testing and the results lose the previous static-analysis validation.

Configure Infection’s static-analysis integration with the project’s chosen analyzer in `infection.json.dist` or pass the corresponding option in both local and CI commands.

Also at `.github/workflows/mutation.yml:33`, `composer.json:48`.

@vjik
vjik merged commit 6b48949 into master Nov 1, 2026
32 checks passed
@vjik
vjik deleted the switch2infection branch November 1, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant