Skip to content

Fix #819: Preserve microsecond precision when comparing date values in UniqueIterable - #819

Merged
samdark merged 3 commits into
masterfrom
fix-unique-iterable-timestamp-precision
Sep 16, 2026
Merged

samdark merged 3 commits into
masterfrom
fix-unique-iterable-timestamp-precision

Conversation

@samdark

@samdark samdark commented Sep 15, 2026

Copy link
Copy Markdown
Member
Q A
Is bugfix? ✔️
New feature?
Breaks BC?

UniqueIterable treats distinct dates within the same second as duplicates because getTimestamp() discards microseconds. For example, 14:05:01.000001 and 14:05:01.000002 currently fail validation.

@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.35%. Comparing base (7259299) to head (545a965).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #819   +/-   ##
=========================================
  Coverage     96.35%   96.35%           
  Complexity     1152     1152           
=========================================
  Files           124      124           
  Lines          3540     3540           
=========================================
  Hits           3411     3411           
  Misses          129      129           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samdark
samdark requested a review from a team September 15, 2026 09:21
Comment thread tests/Rule/UniqueIterableTest.php Outdated
Comment thread tests/Rule/UniqueIterableTest.php Outdated
@vjik vjik added the status:code review The pull request needs review. label Sep 16, 2026
@samdark samdark changed the title Preserve microseconds in UniqueIterable date comparisons Fix #819: Preserve microsecond precision when comparing date values in UniqueIterable Sep 16, 2026
@samdark
samdark merged commit cde9506 into master Sep 16, 2026
39 checks passed
@samdark
samdark deleted the fix-unique-iterable-timestamp-precision branch September 16, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants